Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/arm/nvidia Change tegra_pcie_conf_hook() to only gi...



details:   https://anonhg.NetBSD.org/src/rev/020baaea59cd
branches:  trunk
changeset: 347187:020baaea59cd
user:      jakllsch <jakllsch%NetBSD.org@localhost>
date:      Wed Aug 17 00:22:56 2016 +0000

description:
Change tegra_pcie_conf_hook() to only give us the defaults without
enabled bus mastering.  Previously both bus mastering and ROM decode
were enabled at pci_configure_bus() time.  Both bus mastering and ROM
decode potentially have undesireable side effects.  These can best be
managed by drivers familiar with their hardware.

diffstat:

 sys/arch/arm/nvidia/tegra_pcie.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r e83f77b33bd0 -r 020baaea59cd sys/arch/arm/nvidia/tegra_pcie.c
--- a/sys/arch/arm/nvidia/tegra_pcie.c  Wed Aug 17 00:10:19 2016 +0000
+++ b/sys/arch/arm/nvidia/tegra_pcie.c  Wed Aug 17 00:22:56 2016 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: tegra_pcie.c,v 1.14 2015/12/13 17:39:19 jmcneill Exp $ */
+/* $NetBSD: tegra_pcie.c,v 1.15 2016/08/17 00:22:56 jakllsch Exp $ */
 
 /*-
  * Copyright (c) 2015 Jared D. McNeill <jmcneill%invisible.ca@localhost>
@@ -27,7 +27,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: tegra_pcie.c,v 1.14 2015/12/13 17:39:19 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: tegra_pcie.c,v 1.15 2016/08/17 00:22:56 jakllsch Exp $");
 
 #include <sys/param.h>
 #include <sys/bus.h>
@@ -538,7 +538,7 @@
 static int
 tegra_pcie_conf_hook(void *v, int b, int d, int f, pcireg_t id)
 {
-       return PCI_CONF_ALL;
+       return PCI_CONF_DEFAULT & ~PCI_CONF_ENABLE_BM;
 }
 
 static void



Home | Main Index | Thread Index | Old Index