[src/trunk]: src/common/lib/libprop Don't treat NUL (EOF) as SPACE. All the c...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/83269ad4394d
branches:  trunk
changeset: 338128:83269ad4394d
user:      christos <christos%NetBSD.org@localhost>
date:      Mon May 11 16:50:35 2015 +0000

description:
Don't treat NUL (EOF) as SPACE. All the code that uses _PROP_ISSPACE() checks
explicitly for _PROP_EOF() anyway, and this can be abused to cause run beyond
the end of buffer DoS (Mateusz Kocielski)
XXX: pullup-7

diffstat:

 common/lib/libprop/prop_object_impl.h |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (19 lines):

diff -r 7ad019eb0c96 -r 83269ad4394d common/lib/libprop/prop_object_impl.h
--- a/common/lib/libprop/prop_object_impl.h     Mon May 11 16:48:34 2015 +0000
+++ b/common/lib/libprop/prop_object_impl.h     Mon May 11 16:50:35 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: prop_object_impl.h,v 1.31 2012/07/27 09:10:59 pooka Exp $      */
+/*     $NetBSD: prop_object_impl.h,v 1.32 2015/05/11 16:50:35 christos Exp $   */
 
 /*-
  * Copyright (c) 2006 The NetBSD Foundation, Inc.
@@ -112,8 +112,7 @@
 
 #define        _PROP_EOF(c)            ((c) == '\0')
 #define        _PROP_ISSPACE(c)        \
-       ((c) == ' ' || (c) == '\t' || (c) == '\n' || (c) == '\r' || \
-        _PROP_EOF(c))
+       ((c) == ' ' || (c) == '\t' || (c) == '\n' || (c) == '\r')
 
 #define        _PROP_TAG_MATCH(ctx, t)                                 \
        _prop_object_internalize_match((ctx)->poic_tagname,     \