Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/nand update for GCC 6:



details:   https://anonhg.NetBSD.org/src/rev/487e3ccb6026
branches:  trunk
changeset: 359363:487e3ccb6026
user:      mrg <mrg%NetBSD.org@localhost>
date:      Thu Feb 08 07:48:19 2018 +0000

description:
update for GCC 6:
- nand_bbt_block_mark() has a left-shift of negative value issue.
  this change avoids it, but reviewers indicate this function has
  other problems.

diffstat:

 sys/dev/nand/nand_bbt.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 3cf2d287731e -r 487e3ccb6026 sys/dev/nand/nand_bbt.c
--- a/sys/dev/nand/nand_bbt.c   Thu Feb 08 07:11:20 2018 +0000
+++ b/sys/dev/nand/nand_bbt.c   Thu Feb 08 07:48:19 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: nand_bbt.c,v 1.7 2013/10/22 01:01:27 htodd Exp $       */
+/*     $NetBSD: nand_bbt.c,v 1.8 2018/02/08 07:48:19 mrg Exp $ */
 
 /*-
  * Copyright (c) 2011 Department of Software Engineering,
@@ -36,7 +36,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nand_bbt.c,v 1.7 2013/10/22 01:01:27 htodd Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nand_bbt.c,v 1.8 2018/02/08 07:48:19 mrg Exp $");
 
 #include <sys/param.h>
 #include <sys/kmem.h>
@@ -208,7 +208,7 @@
        __USE(chip);
        KASSERT(block < chip->nc_size / chip->nc_block_size);
 
-       clean = (~0x03 << ((block % 4) * 2));
+       clean = (0xfc << ((block % 4) * 2));
        marker = (marker << ((block % 4) * 2));
 
        /* set byte containing the 2 bit marker for this block */



Home | Main Index | Thread Index | Old Index