[src/trunk]: src/sys/dev/pci Fix to print the following bit fields correctly.

[msaitoh <msaitoh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/cbb055487840
branches:  trunk
changeset: 354199:cbb055487840
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Wed Jun 07 05:30:49 2017 +0000

description:
Fix to print the following bit fields correctly.
  -  Supported Link Speeds Vector in LCAP2
  -  Lower SKP OS Generation Supported Speed Vector  in LCAP2
  -  Lower SKP OS Reception Supported Speed Vector in LCAP2
  -  Enable Lower SKP OS Generation Vector in LCTL3

Note that the above bitfields start from 0 and the follwing bitfields start
from 1:
  -  Maximum Link Speed in LCAP
  -  Current Link Speed in LCSR
  -  Target Link Speed in LCSR2

diffstat:

 sys/dev/pci/pci_subr.c |  28 ++++++++++++++++++++++------
 1 files changed, 22 insertions(+), 6 deletions(-)

diffs (57 lines):

diff -r e77caff1f258 -r cbb055487840 sys/dev/pci/pci_subr.c
--- a/sys/dev/pci/pci_subr.c    Wed Jun 07 05:26:19 2017 +0000
+++ b/sys/dev/pci/pci_subr.c    Wed Jun 07 05:30:49 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pci_subr.c,v 1.184 2017/06/05 13:35:33 msaitoh Exp $   */
+/*     $NetBSD: pci_subr.c,v 1.185 2017/06/07 05:30:49 msaitoh Exp $   */
 
 /*
  * Copyright (c) 1997 Zubin D. Dittia.  All rights reserved.
@@ -40,7 +40,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: pci_subr.c,v 1.184 2017/06/05 13:35:33 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pci_subr.c,v 1.185 2017/06/07 05:30:49 msaitoh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_pci.h"
@@ -1606,18 +1606,34 @@
        }
 }
 
-static const char * const pcie_linkspeeds[] = {"2.5", "2.5", "5.0", "8.0"};
-
+static const char * const pcie_linkspeeds[] = {"2.5", "5.0", "8.0"};
+
+/*
+ * Print link speed. This function is used for the following register bits:
+ *   Maximum Link Speed in LCAP
+ *   Current Link Speed in LCSR
+ *   Target Link Speed in LCSR2
+ * All of above bitfield's values start from 1.
+ */
 static void
 pci_print_pcie_linkspeed(pcireg_t val)
 {
 
-       if (val > __arraycount(pcie_linkspeeds))
+       if ((val < 1) || (val > __arraycount(pcie_linkspeeds)))
                printf("unknown value (%u)\n", val);
        else
-               printf("%sGT/s\n", pcie_linkspeeds[val]);
+               printf("%sGT/s\n", pcie_linkspeeds[val - 1]);
 }
 
+/*
+ * Print link speed "vector".
+ * This function is used for the following register bits:
+ *   Supported Link Speeds Vector in LCAP2
+ *   Lower SKP OS Generation Supported Speed Vector  in LCAP2
+ *   Lower SKP OS Reception Supported Speed Vector in LCAP2
+ *   Enable Lower SKP OS Generation Vector in LCTL3
+ * All of above bitfield's values start from 0.
+ */
 static void
 pci_print_pcie_linkspeedvector(pcireg_t val)
 {