Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch Add -fno-shrink-wrap, to force GCC to push the fram...



details:   https://anonhg.NetBSD.org/src/rev/770ba9b57203
branches:  trunk
changeset: 359739:770ba9b57203
user:      maxv <maxv%NetBSD.org@localhost>
date:      Fri Feb 23 09:00:55 2018 +0000

description:
Add -fno-shrink-wrap, to force GCC to push the frames at the very beginning
of the functions. Otherwise DDB is unable to display a correct stack trace
if a fault occurred in a function before the frame was pushed.

Discussed on tech-kern@, flag suggested by Krister Walfridsson. Should fix
PR/52560.

diffstat:

 sys/arch/amd64/conf/Makefile.amd64 |  4 ++--
 sys/arch/i386/conf/Makefile.i386   |  4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diffs (36 lines):

diff -r d06823058baa -r 770ba9b57203 sys/arch/amd64/conf/Makefile.amd64
--- a/sys/arch/amd64/conf/Makefile.amd64        Fri Feb 23 03:33:36 2018 +0000
+++ b/sys/arch/amd64/conf/Makefile.amd64        Fri Feb 23 09:00:55 2018 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: Makefile.amd64,v 1.64 2017/11/15 18:02:37 maxv Exp $
+#      $NetBSD: Makefile.amd64,v 1.65 2018/02/23 09:00:56 maxv Exp $
 
 # Makefile for NetBSD
 #
@@ -35,7 +35,7 @@
 ##
 DEFCOPTS=      -O2 -fno-omit-frame-pointer
 CPPFLAGS+=     -Damd64 -Dx86_64
-CFLAGS+=       -mcmodel=kernel
+CFLAGS+=       -mcmodel=kernel -fno-shrink-wrap
 # -mno-sse implies -mno-sse2 (etc), explicitly disable avx to be extra sure
 CFLAGS+=       -mno-red-zone -mno-mmx -mno-sse -mno-avx
 # make absolutely sure we don't get x87 registers used as well
diff -r d06823058baa -r 770ba9b57203 sys/arch/i386/conf/Makefile.i386
--- a/sys/arch/i386/conf/Makefile.i386  Fri Feb 23 03:33:36 2018 +0000
+++ b/sys/arch/i386/conf/Makefile.i386  Fri Feb 23 09:00:55 2018 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: Makefile.i386,v 1.187 2017/12/10 14:29:47 christos Exp $
+#      $NetBSD: Makefile.i386,v 1.188 2018/02/23 09:00:55 maxv Exp $
 
 # Makefile for NetBSD
 #
@@ -35,7 +35,7 @@
 ##
 DEFCOPTS=      -O2 -fno-omit-frame-pointer
 CPPFLAGS+=     -Di386
-CFLAGS+=       -msoft-float
+CFLAGS+=       -msoft-float -fno-shrink-wrap
 ## no-sse implies no-sse2 but not no-avx
 CFLAGS+=       -mno-mmx -mno-sse -mno-avx
 



Home | Main Index | Thread Index | Old Index