[src/trunk]: src/sys/dev/ic - don't leak ccb on alloc failure.

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/44b09bb9861b
branches:  trunk
changeset: 359864:44b09bb9861b
user:      christos <christos%NetBSD.org@localhost>
date:      Tue Feb 27 12:59:53 2018 +0000

description:
- don't leak ccb on alloc failure.
- KASSERT to prevent memory leak.

diffstat:

 sys/dev/ic/nvme.c |  9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diffs (38 lines):

diff -r 8ef0009564d5 -r 44b09bb9861b sys/dev/ic/nvme.c
--- a/sys/dev/ic/nvme.c Tue Feb 27 12:20:35 2018 +0000
+++ b/sys/dev/ic/nvme.c Tue Feb 27 12:59:53 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: nvme.c,v 1.31 2017/10/28 04:53:55 riastradh Exp $      */
+/*     $NetBSD: nvme.c,v 1.32 2018/02/27 12:59:53 christos Exp $       */
 /*     $OpenBSD: nvme.c,v 1.49 2016/04/18 05:59:50 dlg Exp $ */
 
 /*
@@ -18,7 +18,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nvme.c,v 1.31 2017/10/28 04:53:55 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nvme.c,v 1.32 2018/02/27 12:59:53 christos Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -570,8 +570,10 @@
        KASSERT(ccb != NULL); /* it's a bug if we don't have spare ccb here */
 
        mem = nvme_dmamem_alloc(sc, sizeof(*identify));
-       if (mem == NULL)
+       if (mem == NULL) {
+               nvme_ccb_put(sc->sc_admin_q, ccb);
                return ENOMEM;
+       }
 
        memset(&sqe, 0, sizeof(sqe));
        sqe.opcode = NVM_ADMIN_IDENTIFY;
@@ -601,6 +603,7 @@
 
        ns = nvme_ns_get(sc, nsid);
        KASSERT(ns);
+       KASSERT(ns->ident == NULL);
        ns->ident = identify;
 
 done: