[src/trunk]: src/sys/arch/x86/x86 Remove these two KASSERTs. Thinking about i...

[maxv <maxv%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/37e5e4004b52
branches:  trunk
changeset: 359931:37e5e4004b52
user:      maxv <maxv%NetBSD.org@localhost>
date:      Thu Mar 01 16:49:06 2018 +0000

description:
Remove these two KASSERTs. Thinking about it, they may fire when the user
enters "sysctl -w machdep.svs.enabled=0", if the xcall is received between
the 'svs_enabled' check in the caller and the same check in these KASSERTs.

In such a case we perform an SVS operation with svs_enabled set to false,
but that's intentional: after it is done svs_pmap_sync and svs_lwp_switch
won't be called anymore, the pdir synchronization is dropped.

Having said that, I didn't see these KASSERTs getting triggered.

diffstat:

 sys/arch/x86/x86/svs.c |  7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diffs (35 lines):

diff -r 5f9b438c5d9d -r 37e5e4004b52 sys/arch/x86/x86/svs.c
--- a/sys/arch/x86/x86/svs.c    Thu Mar 01 16:03:02 2018 +0000
+++ b/sys/arch/x86/x86/svs.c    Thu Mar 01 16:49:06 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: svs.c,v 1.12 2018/02/25 13:15:35 maxv Exp $    */
+/*     $NetBSD: svs.c,v 1.13 2018/03/01 16:49:06 maxv Exp $    */
 
 /*
  * Copyright (c) 2018 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: svs.c,v 1.12 2018/02/25 13:15:35 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: svs.c,v 1.13 2018/03/01 16:49:06 maxv Exp $");
 
 #include "opt_svs.h"
 
@@ -455,7 +455,6 @@
        struct cpu_info *ci;
        cpuid_t cid;
 
-       KASSERT(svs_enabled);
        KASSERT(pmap != NULL);
        KASSERT(pmap != pmap_kernel());
        KASSERT(mutex_owned(pmap->pm_lock));
@@ -488,8 +487,6 @@
        uintptr_t rsp0;
        vaddr_t va;
 
-       KASSERT(svs_enabled);
-
        if (newlwp->l_flag & LW_SYSTEM) {
                return;
        }