Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb Do not turn on IFF_OACTIVE if transfer fails.



details:   https://anonhg.NetBSD.org/src/rev/9a349845ac0a
branches:  trunk
changeset: 433469:9a349845ac0a
user:      rin <rin%NetBSD.org@localhost>
date:      Sun Sep 16 01:29:28 2018 +0000

description:
Do not turn on IFF_OACTIVE if transfer fails.
Remove redundant error message.

diffstat:

 sys/dev/usb/if_mue.c |  7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diffs (28 lines):

diff -r 782a16d94c92 -r 9a349845ac0a sys/dev/usb/if_mue.c
--- a/sys/dev/usb/if_mue.c      Sun Sep 16 01:27:21 2018 +0000
+++ b/sys/dev/usb/if_mue.c      Sun Sep 16 01:29:28 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_mue.c,v 1.13 2018/09/16 01:27:21 rin Exp $  */
+/*     $NetBSD: if_mue.c,v 1.14 2018/09/16 01:29:28 rin Exp $  */
 /*     $OpenBSD: if_mue.c,v 1.3 2018/08/04 16:42:46 jsg Exp $  */
 
 /*
@@ -20,7 +20,7 @@
 /* Driver for Microchip LAN7500/LAN7800 chipsets. */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_mue.c,v 1.13 2018/09/16 01:27:21 rin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_mue.c,v 1.14 2018/09/16 01:29:28 rin Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -1707,8 +1707,7 @@
                return;
 
        if (__predict_false(mue_encap(sc, m, 0))) {
-               DPRINTF(sc, "encap failed\n");
-               ifp->if_flags |= IFF_OACTIVE;
+               ifp->if_oerrors++;
                return;
        }
        IFQ_DEQUEUE(&ifp->if_snd, m);



Home | Main Index | Thread Index | Old Index