Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb Avoid signed/unsigned comparision (if_mtu is uin...



details:   https://anonhg.NetBSD.org/src/rev/8d113f33bcc8
branches:  trunk
changeset: 446579:8d113f33bcc8
user:      martin <martin%NetBSD.org@localhost>
date:      Tue Dec 11 16:45:49 2018 +0000

description:
Avoid signed/unsigned comparision (if_mtu is uint64_t)

diffstat:

 sys/dev/usb/if_mue.c |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r 48b79fd879fa -r 8d113f33bcc8 sys/dev/usb/if_mue.c
--- a/sys/dev/usb/if_mue.c      Tue Dec 11 14:49:27 2018 +0000
+++ b/sys/dev/usb/if_mue.c      Tue Dec 11 16:45:49 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_mue.c,v 1.22 2018/12/11 13:35:02 rin Exp $  */
+/*     $NetBSD: if_mue.c,v 1.23 2018/12/11 16:45:49 martin Exp $       */
 /*     $OpenBSD: if_mue.c,v 1.3 2018/08/04 16:42:46 jsg Exp $  */
 
 /*
@@ -20,7 +20,7 @@
 /* Driver for Microchip LAN7500/LAN7800 chipsets. */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_mue.c,v 1.22 2018/12/11 13:35:02 rin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_mue.c,v 1.23 2018/12/11 16:45:49 martin Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -1218,7 +1218,8 @@
                      M_CSUM_TCPv6 | M_CSUM_UDPv6);
 
        len = m->m_pkthdr.len;
-       if (__predict_false((!tso && len > MUE_FRAME_LEN(ifp->if_mtu)) ||
+       if (__predict_false((!tso && 
+                               (unsigned)len > MUE_FRAME_LEN(ifp->if_mtu)) ||
                            ( tso && len > MUE_TSO_FRAME_LEN))) {
                MUE_PRINTF(sc, "packet length %d\n too long", len);
                return EINVAL;



Home | Main Index | Thread Index | Old Index