Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/net Panic rather than silently dropping packets when TX ...



details:   https://anonhg.NetBSD.org/src/rev/3975df3d0c6d
branches:  trunk
changeset: 446667:3975df3d0c6d
user:      rin <rin%NetBSD.org@localhost>
date:      Thu Dec 13 20:54:50 2018 +0000

description:
Panic rather than silently dropping packets when TX offload options are
enabled for unsupported frame types.

diffstat:

 sys/net/ether_sw_offload.c |  7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diffs (35 lines):

diff -r 309f52f94b91 -r 3975df3d0c6d sys/net/ether_sw_offload.c
--- a/sys/net/ether_sw_offload.c        Thu Dec 13 20:44:33 2018 +0000
+++ b/sys/net/ether_sw_offload.c        Thu Dec 13 20:54:50 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ether_sw_offload.c,v 1.3 2018/12/13 20:44:33 rin Exp $ */
+/*     $NetBSD: ether_sw_offload.c,v 1.4 2018/12/13 20:54:50 rin Exp $ */
 
 /*
  * Copyright (c) 2018 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
 #endif
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ether_sw_offload.c,v 1.3 2018/12/13 20:44:33 rin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ether_sw_offload.c,v 1.4 2018/12/13 20:54:50 rin Exp $");
 
 #include <sys/param.h>
 #include <sys/types.h>
@@ -99,7 +99,7 @@
                ehlen = ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN;
                break;
        default:
-               goto quit;
+               panic("%s: unexpected frame type", __func__);
        }
        KASSERT(m->m_pkthdr.len >= ehlen);
 
@@ -331,7 +331,6 @@
                break;
        default:
                panic("%s: impossible", __func__);
-               break;
        }
 
 done:



Home | Main Index | Thread Index | Old Index