Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/tests Clean up terminology: modern arm CPUs do properly impl...



details:   https://anonhg.NetBSD.org/src/rev/ea02cfe11730
branches:  trunk
changeset: 447998:ea02cfe11730
user:      martin <martin%NetBSD.org@localhost>
date:      Wed Jan 30 12:16:28 2019 +0000

description:
Clean up terminology: modern arm CPUs do properly implement IEEE 754
floating point exceptions - but some (actually all currently know ones)
do not implement sending traps when these exceptions are raised.

Pointed out by Peter Maydell.

diffstat:

 tests/kernel/h_segv.c            |  10 +++++-----
 tests/lib/libc/gen/t_fpsetmask.c |   6 +++---
 tests/lib/libc/gen/t_siginfo.c   |   6 +++---
 tests/lib/libm/t_fenv.c          |  10 +++++-----
 4 files changed, 16 insertions(+), 16 deletions(-)

diffs (118 lines):

diff -r bde804a5507a -r ea02cfe11730 tests/kernel/h_segv.c
--- a/tests/kernel/h_segv.c     Wed Jan 30 11:36:42 2019 +0000
+++ b/tests/kernel/h_segv.c     Wed Jan 30 12:16:28 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: h_segv.c,v 1.12 2019/01/27 16:29:56 christos Exp $     */
+/*     $NetBSD: h_segv.c,v 1.13 2019/01/30 12:16:28 martin Exp $       */
 
 /*-
  * Copyright (c) 2017 The NetBSD Foundation, Inc.
@@ -29,7 +29,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: h_segv.c,v 1.12 2019/01/27 16:29:56 christos Exp $");
+__RCSID("$NetBSD: h_segv.c,v 1.13 2019/01/30 12:16:28 martin Exp $");
 
 #define        __TEST_FENV
 
@@ -113,12 +113,12 @@
 {
 #if (__arm__ && !__SOFTFP__) || __aarch64__
        /*
-        * Some NEON fpus do not implement IEEE exception handling,
-        * skip these tests if running on them and compiled for
+        * Some NEON fpus do not trap on IEEE 754 FP excpeptions.
+        * Skip these tests if running on them and compiled for
         * hard float.
         */
        if (0 == fpsetmask(fpsetmask(FP_X_INV))) {
-               printf("FPU does not implement exception handling\n");
+               printf("FPU does not implement traps on FP exceptions\n");
                exit(EXIT_FAILURE);
        }
 #endif
diff -r bde804a5507a -r ea02cfe11730 tests/lib/libc/gen/t_fpsetmask.c
--- a/tests/lib/libc/gen/t_fpsetmask.c  Wed Jan 30 11:36:42 2019 +0000
+++ b/tests/lib/libc/gen/t_fpsetmask.c  Wed Jan 30 12:16:28 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: t_fpsetmask.c,v 1.18 2019/01/23 17:36:01 martin Exp $ */
+/*     $NetBSD: t_fpsetmask.c,v 1.19 2019/01/30 12:16:28 martin Exp $ */
 
 /*-
  * Copyright (c) 1995 The NetBSD Foundation, Inc.
@@ -60,13 +60,13 @@
 
 #if (__arm__ && !__SOFTFP__) || __aarch64__
        /*
-        * Some NEON fpus do not implement IEEE exception handling,
+        * Some NEON fpus do not trap on IEEE 754 FP excpeptions.
         * skip these tests if running on them and compiled for
         * hard float.
         */
 #define        FPU_PREREQ()                                                    \
        if (0 == fpsetmask(fpsetmask(FP_X_INV)))                        \
-               atf_tc_skip("FPU does not implement exception handling");
+               atf_tc_skip("FPU does not implement traps on FP exceptions");
 #endif
 
 #ifndef FPU_PREREQ
diff -r bde804a5507a -r ea02cfe11730 tests/lib/libc/gen/t_siginfo.c
--- a/tests/lib/libc/gen/t_siginfo.c    Wed Jan 30 11:36:42 2019 +0000
+++ b/tests/lib/libc/gen/t_siginfo.c    Wed Jan 30 12:16:28 2019 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: t_siginfo.c,v 1.34 2019/01/26 15:46:27 martin Exp $ */
+/* $NetBSD: t_siginfo.c,v 1.35 2019/01/30 12:16:28 martin Exp $ */
 
 /*-
  * Copyright (c) 2010 The NetBSD Foundation, Inc.
@@ -311,12 +311,12 @@
                atf_tc_skip("Test does not run correctly under QEMU");
 #if (__arm__ && !__SOFTFP__) || __aarch64__
        /*
-        * Some NEON fpus do not implement IEEE exception handling,
+        * Some NEON fpus do not trap on IEEE 754 FP excpeptions.
         * skip these tests if running on them and compiled for
         * hard float.
         */
        if (0 == fpsetmask(fpsetmask(FP_X_INV)))
-               atf_tc_skip("FPU does not implement exception handling");
+               atf_tc_skip("FPU does not implement traps on FP exceptions");
 #endif
        if (sigsetjmp(sigfpe_flt_env, 0) == 0) {
                sa.sa_flags = SA_SIGINFO;
diff -r bde804a5507a -r ea02cfe11730 tests/lib/libm/t_fenv.c
--- a/tests/lib/libm/t_fenv.c   Wed Jan 30 11:36:42 2019 +0000
+++ b/tests/lib/libm/t_fenv.c   Wed Jan 30 12:16:28 2019 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: t_fenv.c,v 1.4 2019/01/23 17:36:01 martin Exp $ */
+/* $NetBSD: t_fenv.c,v 1.5 2019/01/30 12:16:28 martin Exp $ */
 
 /*-
  * Copyright (c) 2014 The NetBSD Foundation, Inc.
@@ -29,7 +29,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: t_fenv.c,v 1.4 2019/01/23 17:36:01 martin Exp $");
+__RCSID("$NetBSD: t_fenv.c,v 1.5 2019/01/30 12:16:28 martin Exp $");
 
 #include <atf-c.h>
 
@@ -42,13 +42,13 @@
 
 #if (__arm__ && !__SOFTFP__) || __aarch64__
        /*
-        * Some NEON fpus do not implement IEEE exception handling,
-        * skip these tests if running on them and compiled for
+        * Some NEON fpus  do not trap on IEEE 754 FP excpeptions.
+        * Skip these tests if running on them and compiled for
         * hard float.
         */
 #define        FPU_EXC_PREREQ()                                                \
        if (0 == fpsetmask(fpsetmask(FP_X_INV)))                        \
-               atf_tc_skip("FPU does not implement exception handling");
+               atf_tc_skip("FPU does not implement traps on FP exceptions");
 
        /*
         * Same as above: some don't allow configuring the rounding mode.



Home | Main Index | Thread Index | Old Index