Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/doc Add an entry to remind someone(tm) to review the need fo...



details:   https://anonhg.NetBSD.org/src/rev/977c919aef6d
branches:  trunk
changeset: 449041:977c919aef6d
user:      pgoyette <pgoyette%NetBSD.org@localhost>
date:      Wed Feb 20 04:32:51 2019 +0000

description:
Add an entry to remind someone(tm) to review the need for WARNS=3 in
more than 100 modules' Makefile.

diffstat:

 doc/TODO.modules |  9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diffs (20 lines):

diff -r e4911a797254 -r 977c919aef6d doc/TODO.modules
--- a/doc/TODO.modules  Wed Feb 20 03:57:28 2019 +0000
+++ b/doc/TODO.modules  Wed Feb 20 04:32:51 2019 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: TODO.modules,v 1.18 2018/12/28 21:51:49 pgoyette Exp $ */
+/* $NetBSD: TODO.modules,v 1.19 2019/02/20 04:32:51 pgoyette Exp $ */
 
 Some notes on the limitations of our current (as of 7.99.35) module
 subsystem.  This list was triggered by an Email exchange between
@@ -212,3 +212,10 @@
     Additional difficulties arise when the module which defines the
     weak symbol gets unloaded.  Then, you would need to re-run the
     linker and _unresolve_ the weak symbol which is no longer defined.
+
+22. A fairly large number of modules still require a maximum warning
+    level of WARNS=3 due to signed-vs-unsigned integer comparisons.  We
+    really ought to clean these up.  (I haven't looked at them in any
+    detail, but I have to wonder how code that compiles cleanly in a
+    normal kernel has these issues when compiled in a module, when both
+    are done with WARNS=5).



Home | Main Index | Thread Index | Old Index