Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/sys/dev/pci Fix a wrong and extra ether_ioctl() call in alc_...
details: https://anonhg.NetBSD.org/src/rev/a18ca86bcb1a
branches: trunk
changeset: 450963:a18ca86bcb1a
user: msaitoh <msaitoh%NetBSD.org@localhost>
date: Wed May 01 12:31:51 2019 +0000
description:
Fix a wrong and extra ether_ioctl() call in alc_ioctl(). _IOWR types call
broke ifreq by the first ether_ioct() and the second ether_ioctl() caused
unexpected behavior. One of bug example is that SIOCGIFMEDIA always failed.
This bug was added in if_alc.c rev. 1.16.
XXX pullup-8
diffstat:
sys/dev/pci/if_alc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diffs (17 lines):
diff -r b234001a0b61 -r a18ca86bcb1a sys/dev/pci/if_alc.c
--- a/sys/dev/pci/if_alc.c Wed May 01 10:43:55 2019 +0000
+++ b/sys/dev/pci/if_alc.c Wed May 01 12:31:51 2019 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: if_alc.c,v 1.32 2019/04/22 09:08:14 msaitoh Exp $ */
+/* $NetBSD: if_alc.c,v 1.33 2019/05/01 12:31:51 msaitoh Exp $ */
/* $OpenBSD: if_alc.c,v 1.1 2009/08/08 09:31:13 kevlo Exp $ */
/*-
* Copyright (c) 2009, Pyun YongHyeon <yongari%FreeBSD.org@localhost>
@@ -2054,7 +2054,6 @@
s = splnet();
- error = ether_ioctl(ifp, cmd, data);
switch (cmd) {
case SIOCSIFADDR:
ifp->if_flags |= IFF_UP;
Home |
Main Index |
Thread Index |
Old Index