[src/trunk]: src/sys/dev/ic Don't set Phase Tag bit of Completion Queue entry...

[nonaka <nonaka%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/bc67282f16e7
branches:  trunk
changeset: 454512:bc67282f16e7
user:      nonaka <nonaka%NetBSD.org@localhost>
date:      Fri Sep 20 05:32:42 2019 +0000

description:
Don't set Phase Tag bit of Completion Queue entry at nvme_poll_done().

A new completion queue entry check incorrectly determined that there was
a Completion Queue entry for a command that was not submitted.

Fix PR kern/54275, PR kern/54503, PR kern/54532.

diffstat:

 sys/dev/ic/nvme.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r c0fdbae6be8f -r bc67282f16e7 sys/dev/ic/nvme.c
--- a/sys/dev/ic/nvme.c Thu Sep 19 18:29:55 2019 +0000
+++ b/sys/dev/ic/nvme.c Fri Sep 20 05:32:42 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: nvme.c,v 1.44 2019/06/28 15:08:47 jmcneill Exp $       */
+/*     $NetBSD: nvme.c,v 1.45 2019/09/20 05:32:42 nonaka Exp $ */
 /*     $OpenBSD: nvme.c,v 1.49 2016/04/18 05:59:50 dlg Exp $ */
 
 /*
@@ -18,7 +18,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nvme.c,v 1.44 2019/06/28 15:08:47 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nvme.c,v 1.45 2019/09/20 05:32:42 nonaka Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1302,8 +1302,8 @@
 {
        struct nvme_poll_state *state = ccb->ccb_cookie;
 
-       SET(cqe->flags, htole16(NVME_CQE_PHASE));
        state->c = *cqe;
+       SET(state->c.flags, htole16(NVME_CQE_PHASE));
 
        ccb->ccb_cookie = state->cookie;
        state->done(q, ccb, &state->c);