[src/trunk]: src/sys/dev/pci Fix ASIC check, BGE_ASICREV(sc->bge_chipid) is n...

[bouyer <bouyer%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/2f10c6d84ec8
branches:  trunk
changeset: 455534:2f10c6d84ec8
user:      bouyer <bouyer%NetBSD.org@localhost>
date:      Fri Apr 05 18:14:54 2019 +0000

description:
Fix ASIC check, BGE_ASICREV(sc->bge_chipid) is not a chipid.
Fixes bogus input error reporting in stat. This is cosmetic, exept for
routed(8) which thinks that the interface is broken and stops accepting routes
from it.

diffstat:

 sys/dev/pci/if_bge.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (29 lines):

diff -r 2b7fbe592430 -r 2f10c6d84ec8 sys/dev/pci/if_bge.c
--- a/sys/dev/pci/if_bge.c      Fri Apr 05 16:14:07 2019 +0000
+++ b/sys/dev/pci/if_bge.c      Fri Apr 05 18:14:54 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_bge.c,v 1.327 2019/02/20 17:00:20 msaitoh Exp $     */
+/*     $NetBSD: if_bge.c,v 1.328 2019/04/05 18:14:54 bouyer Exp $      */
 
 /*
  * Copyright (c) 2001 Wind River Systems
@@ -79,7 +79,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_bge.c,v 1.327 2019/02/20 17:00:20 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_bge.c,v 1.328 2019/04/05 18:14:54 bouyer Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -4767,8 +4767,8 @@
         * ignore the counter
         */
        if (BGE_ASICREV(sc->bge_chipid) != BGE_ASICREV_BCM5717 &&
-           BGE_ASICREV(sc->bge_chipid) != BGE_CHIPID_BCM5719_A0 &&
-           BGE_ASICREV(sc->bge_chipid) != BGE_CHIPID_BCM5720_A0) {
+           sc->bge_chipid != BGE_CHIPID_BCM5719_A0 &&
+           sc->bge_chipid != BGE_CHIPID_BCM5720_A0) {
                ifp->if_ierrors += CSR_READ_4(sc, BGE_RXLP_LOCSTAT_IFIN_DROPS);
        }
        ifp->if_ierrors += CSR_READ_4(sc, BGE_RXLP_LOCSTAT_IFIN_ERRORS);