[src/trunk]: src/sys/dev/usb Preserve the toggleCarry bit in the Endpoint Des...

[gson <gson%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/936ca63ddd1a
branches:  trunk
changeset: 465575:936ca63ddd1a
user:      gson <gson%NetBSD.org@localhost>
date:      Fri Nov 29 14:13:04 2019 +0000

description:
Preserve the toggleCarry bit in the Endpoint Descriptor when handling
a DataUnderrun condition.  Fixes PR kern/54070.

diffstat:

 sys/dev/usb/ohci.c |  9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diffs (30 lines):

diff -r daa04476a51c -r 936ca63ddd1a sys/dev/usb/ohci.c
--- a/sys/dev/usb/ohci.c        Fri Nov 29 12:42:53 2019 +0000
+++ b/sys/dev/usb/ohci.c        Fri Nov 29 14:13:04 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ohci.c,v 1.290 2019/08/11 22:55:03 mrg Exp $   */
+/*     $NetBSD: ohci.c,v 1.291 2019/11/29 14:13:04 gson Exp $  */
 
 /*
  * Copyright (c) 1998, 2004, 2005, 2012 The NetBSD Foundation, Inc.
@@ -41,7 +41,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ohci.c,v 1.290 2019/08/11 22:55:03 mrg Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ohci.c,v 1.291 2019/11/29 14:13:04 gson Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -1515,8 +1515,9 @@
 
                        ohci_soft_ed_t *sed = opipe->sed;
 
-                       /* clear halt and TD chain */
-                       sed->ed.ed_headp = HTOO32(p->physaddr);
+                       /* clear halt and TD chain, preserving toggle carry */
+                       sed->ed.ed_headp = HTOO32(p->physaddr |
+                           (O32TOH(sed->ed.ed_headp) & OHCI_TOGGLECARRY));
                        usb_syncmem(&sed->dma,
                            sed->offs + offsetof(ohci_ed_t, ed_headp),
                            sizeof(sed->ed.ed_headp),