Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/sys/kern - Allocate the ktrace operation header on the stack...
details: https://anonhg.NetBSD.org/src/rev/0088cc581f3b
branches: trunk
changeset: 485125:0088cc581f3b
user: thorpej <thorpej%NetBSD.org@localhost>
date: Wed Apr 19 19:14:17 2000 +0000
description:
- Allocate the ktrace operation header on the stack rather than using
MALLOC()/FREE().
- In ktrgenio():
- Don't allocate the entire size of the I/O for the temporary
buffer used to write the data to the trace file. Instead,
do it in page-sized chunks.
- As in uiomove(), preempt the process if we are hogging the CPU.
- If writing to the trace file errors, abort rather than continuing
to loop through the buffer.
>From Artur Grabowski <art%stacken.kth.se@localhost>, with some additional cleanup
by me.
diffstat:
sys/kern/kern_ktrace.c | 185 ++++++++++++++++++++++++++----------------------
1 files changed, 101 insertions(+), 84 deletions(-)
diffs (truncated from 397 to 300 lines):
diff -r 035efc168970 -r 0088cc581f3b sys/kern/kern_ktrace.c
--- a/sys/kern/kern_ktrace.c Wed Apr 19 16:17:45 2000 +0000
+++ b/sys/kern/kern_ktrace.c Wed Apr 19 19:14:17 2000 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: kern_ktrace.c,v 1.38 1999/07/25 13:59:08 darrenr Exp $ */
+/* $NetBSD: kern_ktrace.c,v 1.39 2000/04/19 19:14:17 thorpej Exp $ */
/*
* Copyright (c) 1989, 1993
@@ -53,11 +53,11 @@
#include <sys/mount.h>
#include <sys/syscallargs.h>
-struct ktr_header *ktrgetheader __P((int));
-int ktrops __P((struct proc *, struct proc *, int, int, void *));
-int ktrsetchildren __P((struct proc *, struct proc *, int, int, void *));
-void ktrwrite __P((struct proc *, void *, struct ktr_header *));
-int ktrcanset __P((struct proc *, struct proc *));
+void ktrinitheader __P((struct ktr_header *, struct proc *, int));
+int ktrops __P((struct proc *, struct proc *, int, int, void *));
+int ktrsetchildren __P((struct proc *, struct proc *, int, int, void *));
+int ktrwrite __P((struct proc *, void *, struct ktr_header *));
+int ktrcanset __P((struct proc *, struct proc *));
void
ktrderef(p)
@@ -95,21 +95,18 @@
}
}
-struct ktr_header *
-ktrgetheader(type)
+void
+ktrinitheader(kth, p, type)
+ struct ktr_header *kth;
+ struct proc *p;
int type;
{
- struct ktr_header *kth;
- struct proc *p = curproc; /* XXX */
- MALLOC(kth, struct ktr_header *, sizeof(struct ktr_header),
- M_TEMP, M_WAITOK);
+ memset(kth, 0, sizeof(*kth));
kth->ktr_type = type;
microtime(&kth->ktr_time);
kth->ktr_pid = p->p_pid;
memcpy(kth->ktr_comm, p->p_comm, MAXCOMLEN);
- /* Note: ktr_len and ktr_buf are left to be filled in by the caller. */
- return (kth);
}
void
@@ -119,26 +116,25 @@
size_t argsize;
register_t args[];
{
- struct ktr_header *kth;
- struct ktr_syscall *ktp;
+ struct ktr_header kth;
+ struct ktr_syscall *ktp;
struct proc *p = curproc; /* XXX */
register_t *argp;
- int len = sizeof(struct ktr_syscall) + argsize;
+ size_t len = sizeof(struct ktr_syscall) + argsize;
int i;
p->p_traceflag |= KTRFAC_ACTIVE;
- kth = ktrgetheader(KTR_SYSCALL);
- MALLOC(ktp, struct ktr_syscall *, len, M_TEMP, M_WAITOK);
+ ktrinitheader(&kth, p, KTR_SYSCALL);
+ ktp = malloc(len, M_TEMP, M_WAITOK);
ktp->ktr_code = code;
ktp->ktr_argsize = argsize;
argp = (register_t *)((char *)ktp + sizeof(struct ktr_syscall));
for (i = 0; i < (argsize / sizeof(*argp)); i++)
*argp++ = args[i];
- kth->ktr_buf = (caddr_t)ktp;
- kth->ktr_len = len;
- ktrwrite(p, v, kth);
- FREE(ktp, M_TEMP);
- FREE(kth, M_TEMP);
+ kth.ktr_buf = (caddr_t)ktp;
+ kth.ktr_len = len;
+ (void) ktrwrite(p, v, &kth);
+ free(ktp, M_TEMP);
p->p_traceflag &= ~KTRFAC_ACTIVE;
}
@@ -149,22 +145,21 @@
int error;
register_t retval;
{
- struct ktr_header *kth;
+ struct ktr_header kth;
struct ktr_sysret ktp;
struct proc *p = curproc; /* XXX */
p->p_traceflag |= KTRFAC_ACTIVE;
- kth = ktrgetheader(KTR_SYSRET);
+ ktrinitheader(&kth, p, KTR_SYSRET);
ktp.ktr_code = code;
ktp.ktr_eosys = 0; /* XXX unused */
ktp.ktr_error = error;
ktp.ktr_retval = retval; /* what about val2 ? */
- kth->ktr_buf = (caddr_t)&ktp;
- kth->ktr_len = sizeof(struct ktr_sysret);
+ kth.ktr_buf = (caddr_t)&ktp;
+ kth.ktr_len = sizeof(struct ktr_sysret);
- ktrwrite(p, v, kth);
- FREE(kth, M_TEMP);
+ (void) ktrwrite(p, v, &kth);
p->p_traceflag &= ~KTRFAC_ACTIVE;
}
@@ -173,16 +168,15 @@
void *v;
char *path;
{
- struct ktr_header *kth;
+ struct ktr_header kth;
struct proc *p = curproc; /* XXX */
p->p_traceflag |= KTRFAC_ACTIVE;
- kth = ktrgetheader(KTR_NAMEI);
- kth->ktr_len = strlen(path);
- kth->ktr_buf = path;
+ ktrinitheader(&kth, p, KTR_NAMEI);
+ kth.ktr_len = strlen(path);
+ kth.ktr_buf = path;
- ktrwrite(p, v, kth);
- FREE(kth, M_TEMP);
+ (void) ktrwrite(p, v, &kth);
p->p_traceflag &= ~KTRFAC_ACTIVE;
}
@@ -192,15 +186,14 @@
struct proc *p;
char *emul;
{
- struct ktr_header *kth;
+ struct ktr_header kth;
p->p_traceflag |= KTRFAC_ACTIVE;
- kth = ktrgetheader(KTR_EMUL);
- kth->ktr_len = strlen(emul);
- kth->ktr_buf = emul;
+ ktrinitheader(&kth, p, KTR_EMUL);
+ kth.ktr_len = strlen(emul);
+ kth.ktr_buf = emul;
- ktrwrite(p, v, kth);
- FREE(kth, M_TEMP);
+ (void) ktrwrite(p, v, &kth);
p->p_traceflag &= ~KTRFAC_ACTIVE;
}
@@ -212,37 +205,55 @@
struct iovec *iov;
int len, error;
{
- struct ktr_header *kth;
+ struct ktr_header kth;
struct ktr_genio *ktp;
caddr_t cp;
int resid = len, cnt;
struct proc *p = curproc; /* XXX */
-
+ int buflen;
+
if (error)
return;
+
p->p_traceflag |= KTRFAC_ACTIVE;
- kth = ktrgetheader(KTR_GENIO);
- MALLOC(ktp, struct ktr_genio *, sizeof(struct ktr_genio) + len,
- M_TEMP, M_WAITOK);
+
+ buflen = min(PAGE_SIZE, len + sizeof(struct ktr_genio));
+
+ ktrinitheader(&kth, p, KTR_GENIO);
+ ktp = malloc(buflen, M_TEMP, M_WAITOK);
ktp->ktr_fd = fd;
ktp->ktr_rw = rw;
+
+ kth.ktr_buf = (caddr_t)ktp;
+
cp = (caddr_t)((char *)ktp + sizeof(struct ktr_genio));
+ buflen -= sizeof(struct ktr_genio);
+
while (resid > 0) {
- if ((cnt = iov->iov_len) > resid)
+ if (p->p_schedflags & PSCHED_SHOULDYIELD)
+ preempt(NULL);
+
+ cnt = min(iov->iov_len, buflen);
+ if (cnt > resid)
cnt = resid;
- if (copyin(iov->iov_base, cp, (unsigned)cnt))
- goto done;
- cp += cnt;
+ if (copyin(iov->iov_base, cp, cnt))
+ break;
+
+ kth.ktr_len = cnt + sizeof(struct ktr_genio);
+
+ if (ktrwrite(p, v, &kth) != 0)
+ break;
+
+ iov->iov_base = (caddr_t)iov->iov_base + cnt;
+ iov->iov_len -= cnt;
+
+ if (iov->iov_len == 0)
+ iov++;
+
resid -= cnt;
- iov++;
}
- kth->ktr_buf = (caddr_t)ktp;
- kth->ktr_len = sizeof(struct ktr_genio) + len;
- ktrwrite(p, v, kth);
-done:
- FREE(kth, M_TEMP);
- FREE(ktp, M_TEMP);
+ free(ktp, M_TEMP);
p->p_traceflag &= ~KTRFAC_ACTIVE;
}
@@ -254,21 +265,20 @@
sigset_t *mask;
int code;
{
- struct ktr_header *kth;
+ struct ktr_header kth;
struct ktr_psig kp;
struct proc *p = curproc; /* XXX */
p->p_traceflag |= KTRFAC_ACTIVE;
- kth = ktrgetheader(KTR_PSIG);
+ ktrinitheader(&kth, p, KTR_PSIG);
kp.signo = (char)sig;
kp.action = action;
kp.mask = *mask;
kp.code = code;
- kth->ktr_buf = (caddr_t)&kp;
- kth->ktr_len = sizeof(struct ktr_psig);
+ kth.ktr_buf = (caddr_t)&kp;
+ kth.ktr_len = sizeof(struct ktr_psig);
- ktrwrite(p, v, kth);
- FREE(kth, M_TEMP);
+ (void) ktrwrite(p, v, &kth);
p->p_traceflag &= ~KTRFAC_ACTIVE;
}
@@ -277,19 +287,18 @@
void *v;
int out, user;
{
- struct ktr_header *kth;
- struct ktr_csw kc;
+ struct ktr_header kth;
+ struct ktr_csw kc;
struct proc *p = curproc; /* XXX */
p->p_traceflag |= KTRFAC_ACTIVE;
- kth = ktrgetheader(KTR_CSW);
+ ktrinitheader(&kth, p, KTR_CSW);
kc.out = out;
kc.user = user;
- kth->ktr_buf = (caddr_t)&kc;
- kth->ktr_len = sizeof(struct ktr_csw);
+ kth.ktr_buf = (caddr_t)&kc;
+ kth.ktr_len = sizeof(struct ktr_csw);
- ktrwrite(p, v, kth);
- FREE(kth, M_TEMP);
+ (void) ktrwrite(p, v, &kth);
p->p_traceflag &= ~KTRFAC_ACTIVE;
}
@@ -336,7 +345,8 @@
*/
if (KTROP(ops) == KTROP_CLEARFILE) {
proclist_lock_read();
- for (p = allproc.lh_first; p != 0; p = p->p_list.le_next) {
+ for (p = LIST_FIRST(&allproc); p != NULL;
+ p = LIST_NEXT(p, p_list)) {
if (p->p_tracep == fp) {
if (ktrcanset(curp, p))
ktrderef(p);
@@ -366,11 +376,13 @@
error = ESRCH;
goto done;
}
- for (p = pg->pg_members.lh_first; p != 0; p = p->p_pglist.le_next)
Home |
Main Index |
Thread Index |
Old Index