[src/trunk]: src/sys/uvm Remove VM_PROT_EXECUTE from the permissions used to ...

[thorpej <thorpej%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/0c9ff0cfadb2
branches:  trunk
changeset: 486359:0c9ff0cfadb2
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Sat May 20 03:36:06 2000 +0000

description:
Remove VM_PROT_EXECUTE from the permissions used to map the page
for pager I/O -- it is not needed, and including it leads to
unnecessary I-cache flushes.

diffstat:

 sys/uvm/uvm_pager.c |  15 ++-------------
 1 files changed, 2 insertions(+), 13 deletions(-)

diffs (30 lines):

diff -r 889763062ac9 -r 0c9ff0cfadb2 sys/uvm/uvm_pager.c
--- a/sys/uvm/uvm_pager.c       Sat May 20 03:25:14 2000 +0000
+++ b/sys/uvm/uvm_pager.c       Sat May 20 03:36:06 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uvm_pager.c,v 1.29 2000/05/19 03:45:04 thorpej Exp $   */
+/*     $NetBSD: uvm_pager.c,v 1.30 2000/05/20 03:36:06 thorpej Exp $   */
 
 /*
  *
@@ -180,19 +180,8 @@
                if ((pp->flags & PG_BUSY) == 0)
                        panic("uvm_pagermapin: page not busy");
 #endif
-
-               /*
-                * XXX We used to use VM_PROT_DEFAULT here, but
-                * XXX we don't since we know the direction of
-                * XXX the I/O now.  However, VM_PROT_DEFAULT
-                * XXX included VM_PROT_EXECUTE.  While that could
-                * XXX lead to unnecessary I-cache flushes, something
-                * XXX in the path might rely on that being done,
-                * XXX so we still include it, for now.
-                * XXX DOUBLE CHECK THIS!
-                */
                pmap_enter(vm_map_pmap(pager_map), cva, VM_PAGE_TO_PHYS(pp),
-                   prot | VM_PROT_EXECUTE, PMAP_WIRED | prot);
+                   prot, PMAP_WIRED | prot);
        }
 
        UVMHIST_LOG(maphist, "<- done (KVA=0x%x)", kva,0,0,0);