Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci if AC97_CODEC_DOES_VRA is not supported, only pr...



details:   https://anonhg.NetBSD.org/src/rev/6db47ea6b4ce
branches:  trunk
changeset: 499284:6db47ea6b4ce
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Wed Nov 15 21:06:33 2000 +0000

description:
if AC97_CODEC_DOES_VRA is not supported, only print warning than
hw Variable Rate Audio is not supported and continue attaching the driver.
This is I believe more correct than what was done in rev 1.5

diffstat:

 sys/dev/pci/auvia.c |  12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diffs (31 lines):

diff -r b8467155d506 -r 6db47ea6b4ce sys/dev/pci/auvia.c
--- a/sys/dev/pci/auvia.c       Wed Nov 15 20:07:39 2000 +0000
+++ b/sys/dev/pci/auvia.c       Wed Nov 15 21:06:33 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: auvia.c,v 1.6 2000/11/14 18:42:55 thorpej Exp $        */
+/*     $NetBSD: auvia.c,v 1.7 2000/11/15 21:06:33 jdolecek Exp $       */
 
 /*-
  * Copyright (c) 2000 The NetBSD Foundation, Inc.
@@ -289,17 +289,15 @@
        }
 
        /*
-        * Driver works as okay on my VIA 694D Pro with auvia rev. H, even
-        * through the bit won't get set. Earlier models probably need
-        * the test as it is.
+        * Print a warning if the codec doesn't support hardware variable
+        * rate audio.
         */
        if (auvia_read_codec(sc, AC97_REG_EXT_AUDIO_ID, &v)
-               || (sc->sc_revision[0] < 'H' && !(v & AC97_CODEC_DOES_VRA))) {
+               || !(v & AC97_CODEC_DOES_VRA)) {
                /* XXX */
 
-               printf("%s: codec must support AC'97 2.0 Variable Rate Audio\n",
+               printf("%s: warning: codec doesn't support hardware AC'97 2.0 Variable Rate Audio\n",
                        sc->sc_dev.dv_xname);
-               return;
        } else {
                /* enable VRA */
                auvia_write_codec(sc, AC97_REG_EXT_AUDIO_STAT,



Home | Main Index | Thread Index | Old Index