Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/sys Use hardcoded 8192 for PIPE_MINDIRECT, rather than b...



details:   https://anonhg.NetBSD.org/src/rev/fc43401041e4
branches:  trunk
changeset: 516729:fc43401041e4
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Sun Oct 28 20:27:55 2001 +0000

description:
Use hardcoded 8192 for PIPE_MINDIRECT, rather than being dependant
on PAGE_SIZE. The overhead of setting up Page Loan is pretty much constant
irregardless of page size, so it makes more sense to use fixed constant.

According to hbench, the overhead of Page Loan setup is still significantly
bigger than the performance gain for 4096 byte buffers on i386
(PIII/600Mhz). The difference is smaller on 386DX, but Page Loan is
still not faster for this case.

Also, there is some other code out there which expects 4KB writes
to not block even for 'blocking' write, since it works this
way on some other operating systems.
Partially addresses kern/14246 by Andreas Persson.

diffstat:

 sys/sys/pipe.h |  4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diffs (15 lines):

diff -r 9a01b9795f89 -r fc43401041e4 sys/sys/pipe.h
--- a/sys/sys/pipe.h    Sun Oct 28 19:52:53 2001 +0000
+++ b/sys/sys/pipe.h    Sun Oct 28 20:27:55 2001 +0000
@@ -62,11 +62,7 @@
  * than PIPE_BUF.
  */
 #ifndef PIPE_MINDIRECT
-#if defined(__FreeBSD__)
 #define PIPE_MINDIRECT 8192
-#elif defined(__NetBSD__)
-#define PIPE_MINDIRECT PAGE_SIZE
-#endif
 #endif
 
 /*



Home | Main Index | Thread Index | Old Index