[src/trunk]: src/sys/net Fix async map handling. Many thanks to Joerg Wunsch ...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/e3ba55023bd0
branches:  trunk
changeset: 534600:e3ba55023bd0
user:      christos <christos%NetBSD.org@localhost>
date:      Tue Jul 30 13:16:35 2002 +0000

description:
Fix async map handling. Many thanks to Joerg Wunsch for the explanation.

diffstat:

 sys/net/if_spppsubr.c |  32 ++++++++++++++++----------------
 1 files changed, 16 insertions(+), 16 deletions(-)

diffs (54 lines):

diff -r 0e8379002f0b -r e3ba55023bd0 sys/net/if_spppsubr.c
--- a/sys/net/if_spppsubr.c     Tue Jul 30 12:55:08 2002 +0000
+++ b/sys/net/if_spppsubr.c     Tue Jul 30 13:16:35 2002 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_spppsubr.c,v 1.55 2002/07/28 22:16:47 christos Exp $         */
+/*     $NetBSD: if_spppsubr.c,v 1.56 2002/07/30 13:16:35 christos Exp $         */
 
 /*
  * Synchronous PPP/Cisco link level subroutines.
@@ -28,7 +28,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_spppsubr.c,v 1.55 2002/07/28 22:16:47 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_spppsubr.c,v 1.56 2002/07/30 13:16:35 christos Exp $");
 
 #include "opt_inet.h"
 #include "opt_ipx.h"
@@ -2267,21 +2267,21 @@
                        break;
 
                case LCP_OPT_ASYNC_MAP:
-                       /* Async control character map -- check to be zero. */
-                       if (! p[2] && ! p[3] && ! p[4] && ! p[5]) {
-                               if (debug)
-                                       addlog(" [empty]");
-                               continue;
-                       }
-                       if (debug)
-                               addlog(" [non-empty]");
-                       /* suggest a zero one */
-#ifndef BROKEN_98 /* XXX - broken Win98 drivers INSIST on having an ASYNC_MAP */
-                       p[2] = p[3] = p[4] = p[5] = 0;
-                       break;
-#else
+                       /*
+                        * Async control character map -- just ignore it.
+                        *
+                        * Quote from RFC 1662, chapter 6:
+                        * To enable this functionality, synchronous PPP
+                        * implementations MUST always respond to the
+                        * Async-Control-Character-Map Configuration
+                        * Option with the LCP Configure-Ack.  However,
+                        * acceptance of the Configuration Option does
+                        * not imply that the synchronous implementation
+                        * will do any ACCM mapping.  Instead, all such
+                        * octet mapping will be performed by the
+                        * asynchronous-to-synchronous converter.
+                        */
                        continue;
-#endif
 
                case LCP_OPT_MRU:
                        /*