Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/net "if (debug)" some log messages not signaling real er...



details:   https://anonhg.NetBSD.org/src/rev/3fde1e0b1577
branches:  trunk
changeset: 526268:3fde1e0b1577
user:      martin <martin%NetBSD.org@localhost>
date:      Mon Apr 29 16:29:29 2002 +0000

description:
"if (debug)" some log messages not signaling real errors but happening
in normal operation.

diffstat:

 sys/net/if_spppsubr.c |  24 +++++++++++++-----------
 1 files changed, 13 insertions(+), 11 deletions(-)

diffs (52 lines):

diff -r b4abab7d1caf -r 3fde1e0b1577 sys/net/if_spppsubr.c
--- a/sys/net/if_spppsubr.c     Mon Apr 29 16:01:12 2002 +0000
+++ b/sys/net/if_spppsubr.c     Mon Apr 29 16:29:29 2002 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_spppsubr.c,v 1.45 2002/03/02 16:23:42 martin Exp $   */
+/*     $NetBSD: if_spppsubr.c,v 1.46 2002/04/29 16:29:29 martin Exp $   */
 
 /*
  * Synchronous PPP/Cisco link level subroutines.
@@ -28,7 +28,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_spppsubr.c,v 1.45 2002/03/02 16:23:42 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_spppsubr.c,v 1.46 2002/04/29 16:29:29 martin Exp $");
 
 #include "opt_inet.h"
 #include "opt_ipx.h"
@@ -1640,12 +1640,13 @@
                if (upper == NULL)
                        catastrophic++;
 
-               log(LOG_INFO,
-                   SPP_FMT "%s: RXJ%c (%s) for proto 0x%x (%s/%s)\n",
-                   SPP_ARGS(ifp), cp->name, catastrophic ? '-' : '+',
-                   sppp_cp_type_name(h->type), proto,
-                   upper ? upper->name : "unknown",
-                   upper ? sppp_state_name(sp->state[upper->protoidx]) : "?");
+               if (debug)
+                       log(LOG_INFO,
+                           SPP_FMT "%s: RXJ%c (%s) for proto 0x%x (%s/%s)\n",
+                           SPP_ARGS(ifp), cp->name, catastrophic ? '-' : '+',
+                           sppp_cp_type_name(h->type), proto,
+                           upper ? upper->name : "unknown",
+                           upper ? sppp_state_name(sp->state[upper->protoidx]) : "?");
 
                /*
                 * if we got RXJ+ against conf-req, the peer does not implement
@@ -2066,9 +2067,10 @@
         * try to reopen the connection here?
         */
        if ((ifp->if_flags & (IFF_AUTO | IFF_PASSIVE)) == 0) {
-               log(LOG_INFO,
-                   SPP_FMT "Down event (carrier loss), taking interface down.\n",
-                   SPP_ARGS(ifp));
+               if (debug)
+                       log(LOG_INFO,
+                           SPP_FMT "Down event (carrier loss), taking interface down.\n",
+                           SPP_ARGS(ifp));
                if_down(ifp);
        } else {
                if (debug)



Home | Main Index | Thread Index | Old Index