[src/trunk]: src/sys/dev/usb Only complain when opening full speed isoc devic...

[augustss <augustss%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/56b951aed10c
branches:  trunk
changeset: 580623:56b951aed10c
user:      augustss <augustss%NetBSD.org@localhost>
date:      Sun May 01 19:35:07 2005 +0000

description:
Only complain when opening full speed isoc devices, other types seem to
work reasonably (even if there is no proper scheduling of the TT yet).

diffstat:

 sys/dev/usb/ehci.c |  15 ++++++---------
 1 files changed, 6 insertions(+), 9 deletions(-)

diffs (39 lines):

diff -r ef2415e96918 -r 56b951aed10c sys/dev/usb/ehci.c
--- a/sys/dev/usb/ehci.c        Sun May 01 19:24:39 2005 +0000
+++ b/sys/dev/usb/ehci.c        Sun May 01 19:35:07 2005 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ehci.c,v 1.98 2005/05/01 19:24:39 augustss Exp $ */
+/*     $NetBSD: ehci.c,v 1.99 2005/05/01 19:35:07 augustss Exp $ */
 
 /*
  * Copyright (c) 2004 The NetBSD Foundation, Inc.
@@ -65,7 +65,7 @@
 */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ehci.c,v 1.98 2005/05/01 19:24:39 augustss Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ehci.c,v 1.99 2005/05/01 19:35:07 augustss Exp $");
 
 #include "ohci.h"
 #include "uhci.h"
@@ -1380,16 +1380,13 @@
        case USB_SPEED_HIGH: speed = EHCI_QH_SPEED_HIGH; break;
        default: panic("ehci_open: bad device speed %d", dev->speed);
        }
-       if (speed != EHCI_QH_SPEED_HIGH) {
-               printf("%s: *** WARNING: opening low/full speed device, this "
-                      "may not work yet.\n",
+       if (speed != EHCI_QH_SPEED_HIGH && xfertype == UE_ISOCHRONOUS) {
+               printf("%s: *** WARNING: opening low/full speed isoc device, "
+                      "this does not work yet.\n",
                       USBDEVNAME(sc->sc_bus.bdev));
                DPRINTFN(1,("ehci_open: hshubaddr=%d hshubport=%d\n",
                            hshubaddr, hshubport));
-#if 0
-               if (xfertype != UE_CONTROL)
-                       return USBD_INVAL;
-#endif
+               return USBD_INVAL;
        }
 
        naks = 8;               /* XXX */