[src/trunk]: src/sys/dev/isa Add a big comment in the previous section of cod...

[mycroft <mycroft%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/3962f6980a67
branches:  trunk
changeset: 500834:3962f6980a67
user:      mycroft <mycroft%NetBSD.org@localhost>
date:      Tue Dec 19 06:23:26 2000 +0000

description:
Add a big comment in the previous section of code...

diffstat:

 sys/dev/isa/i82365_isasubr.c |  18 ++++++++++++++----
 1 files changed, 14 insertions(+), 4 deletions(-)

diffs (35 lines):

diff -r c8831b4180df -r 3962f6980a67 sys/dev/isa/i82365_isasubr.c
--- a/sys/dev/isa/i82365_isasubr.c      Tue Dec 19 06:04:02 2000 +0000
+++ b/sys/dev/isa/i82365_isasubr.c      Tue Dec 19 06:23:26 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: i82365_isasubr.c,v 1.26 2000/12/19 06:04:02 mycroft Exp $      */
+/*     $NetBSD: i82365_isasubr.c,v 1.27 2000/12/19 06:23:26 mycroft Exp $      */
 
 #define        PCICISADEBUG
 
@@ -472,12 +472,22 @@
        void *ih;
        int reg;
 
+       /*
+        * PLEASE NOTE:
+        * The IRQLEVEL bit has no bearing on what happens on the host side of
+        * the PCMCIA controller.  ISA interrupts are defined to be edge-
+        * triggered, and as this attachment is for ISA devices, the interrupt
+        * *must* be configured for edge-trigger.  If you think you should
+        * change this to use IST_LEVEL, you are *wrong*.  You should figure
+        * out what your real problem is and leave this code alone rather than
+        * breaking everyone else's systems.  - mycroft
+        */
        if (pf->cfe->flags & PCMCIA_CFE_IRQLEVEL)
-               ist = IST_EDGE;
+               ist = IST_EDGE;         /* SEE COMMENT ABOVE */
        else if (pf->cfe->flags & PCMCIA_CFE_IRQPULSE)
-               ist = IST_PULSE;
+               ist = IST_PULSE;        /* SEE COMMENT ABOVE */
        else
-               ist = IST_EDGE;
+               ist = IST_EDGE;         /* SEE COMMENT ABOVE */
 
        if (isa_intr_alloc(ic, sc->intr_mask[h->chip], ist, &irq))
                return (NULL);