Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/share/mk Don't add -Wno-uninitialized to CFLAGS if WARNS > 0...



details:   https://anonhg.NetBSD.org/src/rev/3f1956f0ed48
branches:  trunk
changeset: 581731:3f1956f0ed48
user:      lukem <lukem%NetBSD.org@localhost>
date:      Sat Jun 04 12:17:45 2005 +0000

description:
Don't add -Wno-uninitialized to CFLAGS if WARNS > 0 and HAVE_GCC != no,
as gcc3 generates much less false positives for -Wuninitalized and I
have found genuine bugs with this warning enabled.
Tested by building a full release of NetBSD/i386.

diffstat:

 share/mk/bsd.sys.mk |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (22 lines):

diff -r b2c0efab9887 -r 3f1956f0ed48 share/mk/bsd.sys.mk
--- a/share/mk/bsd.sys.mk       Sat Jun 04 09:33:51 2005 +0000
+++ b/share/mk/bsd.sys.mk       Sat Jun 04 12:17:45 2005 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: bsd.sys.mk,v 1.118 2005/05/31 03:45:42 christos Exp $
+#      $NetBSD: bsd.sys.mk,v 1.119 2005/06/04 12:17:45 lukem Exp $
 #
 # Build definitions used for NetBSD source tree builds.
 
@@ -16,10 +16,10 @@
 # differently in traditional and ansi environments' which is the warning
 # we wanted, and now we don't get anymore.
 CFLAGS+=       -Wno-sign-compare -Wno-traditional
-# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
-# XXX always get it right.
+.if !defined(HAVE_GCC3) || (${HAVE_GCC3} == "no")
 CFLAGS+=       -Wno-uninitialized
 .endif
+.endif
 .if ${WARNS} > 1
 CFLAGS+=       -Wreturn-type -Wswitch -Wshadow
 .endif



Home | Main Index | Thread Index | Old Index