Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic don't limit size of DMA transfer by size of FIFO



details:   https://anonhg.NetBSD.org/src/rev/0030a9ce402e
branches:  trunk
changeset: 558115:0030a9ce402e
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Wed Jan 28 20:08:35 2004 +0000

description:
don't limit size of DMA transfer by size of FIFO
problem reported and fix provided in PR kern/24200 by Paul Shupak

diffstat:

 sys/dev/ic/atppc.c |  9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diffs (31 lines):

diff -r 5d28cf9c0888 -r 0030a9ce402e sys/dev/ic/atppc.c
--- a/sys/dev/ic/atppc.c        Wed Jan 28 20:02:22 2004 +0000
+++ b/sys/dev/ic/atppc.c        Wed Jan 28 20:08:35 2004 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: atppc.c,v 1.9 2004/01/28 14:26:24 drochner Exp $ */
+/* $NetBSD: atppc.c,v 1.10 2004/01/28 20:08:35 jdolecek Exp $ */
 
 /*
  * Copyright (c) 2001 Alcove - Nicolas Souchu
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: atppc.c,v 1.9 2004/01/28 14:26:24 drochner Exp $");
+__KERNEL_RCSID(0, "$NetBSD: atppc.c,v 1.10 2004/01/28 20:08:35 jdolecek Exp $");
 
 #include "opt_atppc.h"
 
@@ -2171,11 +2171,8 @@
                atppc_w_ecr(atppc, ecr);
                atppc_barrier_w(atppc);
                
-               /* Limit transfer to minimum of space in FIFO and buffer */
-               worklen = min(len, atppc->sc_fifo);
-
                /* Limit transfer to maximum DMA size and start it */
-               worklen = min(worklen, atppc->sc_dma_maxsize);
+               worklen = min(len, atppc->sc_dma_maxsize);
                atppc->sc_dmastat = ATPPC_DMA_INIT;
                atppc->sc_dma_start(atppc, atppc->sc_outbstart,
                        worklen, ATPPC_DMA_MODE_WRITE);



Home | Main Index | Thread Index | Old Index