[src/trunk]: src/sys/dev Bogus initializers suck.

[mycroft <mycroft%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/958855db3c09
branches:  trunk
changeset: 554516:958855db3c09
user:      mycroft <mycroft%NetBSD.org@localhost>
date:      Wed Oct 29 03:46:10 2003 +0000

description:
Bogus initializers suck.

diffstat:

 sys/dev/pci/autri.c  |  10 +++++-----
 sys/dev/usb/ezload.c |  11 ++++-------
 2 files changed, 9 insertions(+), 12 deletions(-)

diffs (73 lines):

diff -r b4dd05af0241 -r 958855db3c09 sys/dev/pci/autri.c
--- a/sys/dev/pci/autri.c       Wed Oct 29 03:40:56 2003 +0000
+++ b/sys/dev/pci/autri.c       Wed Oct 29 03:46:10 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: autri.c,v 1.17 2003/10/25 18:31:11 christos Exp $      */
+/*     $NetBSD: autri.c,v 1.18 2003/10/29 03:46:10 mycroft Exp $       */
 
 /*
  * Copyright (c) 2001 SOMEYA Yoshihiko and KUROSAWA Takahiro.
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: autri.c,v 1.17 2003/10/25 18:31:11 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: autri.c,v 1.18 2003/10/29 03:46:10 mycroft Exp $");
 
 #include "midi.h"
 
@@ -423,9 +423,9 @@
                ready = AUTRI_ALI_SCTRL_CODEC_READY;
                break;
        default:
-               addr = 0;
-               ready = 0;
-               break;
+               printf("%s: autri_reset_codec : unknown device\n",
+                      sc->sc_dev.dv_xname);
+               return;
        }
 
        /* wait for 'Codec Ready' */
diff -r b4dd05af0241 -r 958855db3c09 sys/dev/usb/ezload.c
--- a/sys/dev/usb/ezload.c      Wed Oct 29 03:40:56 2003 +0000
+++ b/sys/dev/usb/ezload.c      Wed Oct 29 03:46:10 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ezload.c,v 1.6 2003/10/25 18:28:31 christos Exp $      */
+/*     $NetBSD: ezload.c,v 1.7 2003/10/29 03:52:54 mycroft Exp $       */
 
 /*
  * Copyright (c) 2000 The NetBSD Foundation, Inc.
@@ -37,7 +37,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ezload.c,v 1.6 2003/10/25 18:28:31 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ezload.c,v 1.7 2003/10/29 03:52:54 mycroft Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -112,7 +112,6 @@
 {
        usb_device_request_t req;
        const struct ezdata *ptr;
-       usbd_status err = 0;
        u_int len, offs;
 
        DPRINTF(("ezload_down record=%p\n", rec));
@@ -137,13 +136,11 @@
                                    ptr->address + offs, len));
                        err = usbd_do_request(dev, &req, ptr->data + offs);
                        if (err)
-                               break;
+                               return (err);
                }
-               if (err)
-                       break;
        }
 
-       return (err);
+       return (0);
 }
 
 usbd_status