Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/fs/smbfs SMBERROR() purge - turn into #ifdef DIAGNOSTIC ...



details:   https://anonhg.NetBSD.org/src/rev/352c57b624e3
branches:  trunk
changeset: 543394:352c57b624e3
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Mon Feb 24 10:01:02 2003 +0000

description:
SMBERROR() purge - turn into #ifdef DIAGNOSTIC panics

diffstat:

 sys/fs/smbfs/smbfs_vnops.c |  9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diffs (34 lines):

diff -r 5c71efb191ab -r 352c57b624e3 sys/fs/smbfs/smbfs_vnops.c
--- a/sys/fs/smbfs/smbfs_vnops.c        Mon Feb 24 09:57:31 2003 +0000
+++ b/sys/fs/smbfs/smbfs_vnops.c        Mon Feb 24 10:01:02 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: smbfs_vnops.c,v 1.10 2003/02/23 21:55:20 jdolecek Exp $        */
+/*     $NetBSD: smbfs_vnops.c,v 1.11 2003/02/24 10:01:02 jdolecek Exp $        */
 
 /*-
  * Copyright (c) 2003 The NetBSD Foundation, Inc.
@@ -281,8 +281,10 @@
        smb_makescred(&scred, p, ap->a_cred);
 
        if (np->n_opencount == 0) {
+#ifdef DIAGNOSTIC
                if (vp->v_type != VDIR)
-                       SMBERROR("Negative opencount\n");
+                       panic("smbfs_closel: negative opencount");
+#endif
                return 0;
        }
        np->n_opencount--;
@@ -475,11 +477,10 @@
                                error = smbfs_smb_setftime(np, mtime, atime, &scred);
                        } else {
                                /*
-                                * I have no idea how to handle this for core
+                                * XXX I have no idea how to handle this for core
                                 * level servers. The possible solution is to
                                 * update mtime after file is closed.
                                 */
-                                SMBERROR("can't update times on an opened file\n");
                        }
                }
        }



Home | Main Index | Thread Index | Old Index