Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb Comment out the GET_DEVICE_ID code, because for ...



details:   https://anonhg.NetBSD.org/src/rev/2e31205710a6
branches:  trunk
changeset: 476258:2e31205710a6
user:      augustss <augustss%NetBSD.org@localhost>
date:      Fri Sep 10 19:28:26 1999 +0000

description:
Comment out the GET_DEVICE_ID code, because for some unknown reason it
causes printing to fail sometimes.

diffstat:

 sys/dev/usb/ulpt.c |  20 ++++++++++++++++----
 1 files changed, 16 insertions(+), 4 deletions(-)

diffs (62 lines):

diff -r b678e304e5f5 -r 2e31205710a6 sys/dev/usb/ulpt.c
--- a/sys/dev/usb/ulpt.c        Fri Sep 10 17:32:17 1999 +0000
+++ b/sys/dev/usb/ulpt.c        Fri Sep 10 19:28:26 1999 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ulpt.c,v 1.21 1999/09/09 12:26:45 augustss Exp $       */
+/*     $NetBSD: ulpt.c,v 1.22 1999/09/10 19:28:26 augustss Exp $       */
 
 /*
  * Copyright (c) 1998 The NetBSD Foundation, Inc.
@@ -151,9 +151,6 @@
        usbd_device_handle dev = uaa->device;
        usbd_interface_handle iface = uaa->iface;
        usb_interface_descriptor_t *id = usbd_get_interface_descriptor(iface);
-       usb_config_descriptor_t *cd = usbd_get_config_descriptor(dev);
-       usb_device_request_t req;
-       int len, alen;
        char devinfo[1024];
        usb_endpoint_descriptor_t *ed;
        usbd_status r;
@@ -189,6 +186,17 @@
        }
        sc->sc_ifaceno = id->bInterfaceNumber;
 
+#if 0
+/*
+ * This code is disabled because for some mysterious it causes
+ * printing not to work.  But only sometimes, and mostly with
+ * UHCI and less often with OHCI.  *sigh*
+ */
+       {
+       usb_config_descriptor_t *cd = usbd_get_config_descriptor(dev);
+       usb_device_request_t req;
+       int len, alen;
+
        req.bmRequestType = UT_READ_CLASS_INTERFACE;
        req.bRequest = UR_GET_DEVICE_ID;
        USETW(req.wValue, cd->bConfigurationValue);
@@ -210,6 +218,8 @@
                ieee1284_print_id(devinfo+2);
                printf(">\n");
        }
+       }
+#endif
 
        USB_ATTACH_SUCCESS_RETURN;
 
@@ -478,6 +488,7 @@
        return (error);
 }
 
+#if 0
 /* XXX This does not belong here. */
 /*
  * Print select parts of a IEEE 1284 device ID.
@@ -500,6 +511,7 @@
                }
        }
 }
+#endif
 
 #if defined(__FreeBSD__)
 DRIVER_MODULE(ulpt, usb, ulpt_driver, ulpt_devclass, usbd_driver_load, 0);



Home | Main Index | Thread Index | Old Index