Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/crypto/dist/ipsec-tools Backout botched patch, approved by E...



details:   https://anonhg.NetBSD.org/src/rev/d10adf7985fe
branches:  trunk
changeset: 582965:d10adf7985fe
user:      tron <tron%NetBSD.org@localhost>
date:      Tue Jul 12 19:17:37 2005 +0000

description:
Backout botched patch, approved by Emmanuel Dreyfus.

diffstat:

 crypto/dist/ipsec-tools/ChangeLog               |   4 ----
 crypto/dist/ipsec-tools/src/racoon/isakmp_inf.c |  24 +-----------------------
 2 files changed, 1 insertions(+), 27 deletions(-)

diffs (66 lines):

diff -r a43311809568 -r d10adf7985fe crypto/dist/ipsec-tools/ChangeLog
--- a/crypto/dist/ipsec-tools/ChangeLog Tue Jul 12 16:49:52 2005 +0000
+++ b/crypto/dist/ipsec-tools/ChangeLog Tue Jul 12 19:17:37 2005 +0000
@@ -13,10 +13,6 @@
        * src/racoon/{admin.c|session.c}: Don't use adminport if it is 
          disabled.
 
-2005-07-04  Emmanuel Dreyfus  <manu%netbsd.org@localhost>
-
-       * src/racoon/isakmp_inf.c: safety checks on informational messages
-
 2005-07-01  Emmanuel Dreyfus  <manu%netbsd.org@localhost>
 
        From Uri <urimobile%optonline.net@localhost>
diff -r a43311809568 -r d10adf7985fe crypto/dist/ipsec-tools/src/racoon/isakmp_inf.c
--- a/crypto/dist/ipsec-tools/src/racoon/isakmp_inf.c   Tue Jul 12 16:49:52 2005 +0000
+++ b/crypto/dist/ipsec-tools/src/racoon/isakmp_inf.c   Tue Jul 12 19:17:37 2005 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: isakmp_inf.c,v 1.5 2005/07/12 14:13:10 manu Exp $      */
+/*     $NetBSD: isakmp_inf.c,v 1.6 2005/07/12 19:17:37 tron Exp $      */
 
 /* Id: isakmp_inf.c,v 1.14.4.2 2005/03/02 20:00:03 vanhu Exp */
 
@@ -149,14 +149,6 @@
        } else
                msg = vdup(msg0);
 
-       /* Safety check */
-       if (msg->l < sizeof(*isakmp) + sizeof(*gen)) {
-               plog(LLV_ERROR, LOCATION, NULL, 
-                       "ignore information because the "
-                       "message is way too short\n");
-               goto end;
-       }
-
        isakmp = (struct isakmp *)msg->v;
        gen = (struct isakmp_gen *)((caddr_t)isakmp + sizeof(struct isakmp));
 
@@ -176,14 +168,6 @@
 
        {
                void *p;
-               /* Safety check */
-               if (msg->l < sizeof(*isakmp) + ntohs(gen->len) + sizeof(*nd)) {
-                       plog(LLV_ERROR, LOCATION, NULL, 
-                               "ignore information because the "
-                               "message is too short\n");
-                       goto end;
-               }
-
                vchar_t *hash, *payload;
                struct isakmp_gen *nd;
 
@@ -198,12 +182,6 @@
                        goto end;
                }
 
-               if (ntohs(nd->len) < sizeof(*nd)) {
-                       plog(LLV_ERROR, LOCATION, NULL,
-                               "too short payload length (broken message?)\n");
-                       goto end;
-               }
-
                payload = vmalloc(ntohs(nd->len));
                if (payload == NULL) {
                        plog(LLV_ERROR, LOCATION, NULL,



Home | Main Index | Thread Index | Old Index