Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.bin/tftp A too hasty checkin (and lack of -Wsign-compare...



details:   https://anonhg.NetBSD.org/src/rev/406dc310a255
branches:  trunk
changeset: 498383:406dc310a255
user:      dogcow <dogcow%NetBSD.org@localhost>
date:      Sun Oct 22 01:42:15 2000 +0000

description:
A too hasty checkin (and lack of -Wsign-compare) made send() never fail.
Newly added 'unsigned' removed from vars that shouldn't have had it.

diffstat:

 usr.bin/tftp/tftp.c |  10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diffs (38 lines):

diff -r 82cc6255fb63 -r 406dc310a255 usr.bin/tftp/tftp.c
--- a/usr.bin/tftp/tftp.c       Sun Oct 22 00:44:04 2000 +0000
+++ b/usr.bin/tftp/tftp.c       Sun Oct 22 01:42:15 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: tftp.c,v 1.12 2000/10/18 01:35:45 dogcow Exp $ */
+/*     $NetBSD: tftp.c,v 1.13 2000/10/22 01:42:15 dogcow Exp $ */
 
 /*
  * Copyright (c) 1983, 1993
@@ -38,7 +38,7 @@
 #if 0
 static char sccsid[] = "@(#)tftp.c     8.1 (Berkeley) 6/6/93";
 #else
-__RCSID("$NetBSD: tftp.c,v 1.12 2000/10/18 01:35:45 dogcow Exp $");
+__RCSID("$NetBSD: tftp.c,v 1.13 2000/10/22 01:42:15 dogcow Exp $");
 #endif
 #endif /* not lint */
 
@@ -99,7 +99,8 @@
        struct tftphdr *ap;        /* data and ack packets */
        struct tftphdr *dp;
        int n;
-       volatile unsigned int block, size, convert;
+       volatile unsigned int block;
+       volatile int size, convert;
        volatile unsigned long amount;
        struct sockaddr_storage from;
        int fromlen;
@@ -218,7 +219,8 @@
        struct tftphdr *ap;
        struct tftphdr *dp;
        int n;
-       volatile unsigned int block, size, firsttrip;
+       volatile unsigned int block;
+       volatile int size, firsttrip;
        volatile unsigned long amount;
        struct sockaddr_storage from;
        int fromlen;



Home | Main Index | Thread Index | Old Index