Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic Do not free uninitialize pointers.



details:   https://anonhg.NetBSD.org/src/rev/ce0563e75424
branches:  trunk
changeset: 537861:ce0563e75424
user:      kristerw <kristerw%NetBSD.org@localhost>
date:      Sun Oct 06 23:17:46 2002 +0000

description:
Do not free uninitialize pointers.
Do not try to print with uninitialized format-string pointers.

diffstat:

 sys/dev/ic/mlx.c |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (45 lines):

diff -r 2226129f22c7 -r ce0563e75424 sys/dev/ic/mlx.c
--- a/sys/dev/ic/mlx.c  Sun Oct 06 23:14:25 2002 +0000
+++ b/sys/dev/ic/mlx.c  Sun Oct 06 23:17:46 2002 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: mlx.c,v 1.22 2002/09/27 03:18:13 thorpej Exp $ */
+/*     $NetBSD: mlx.c,v 1.23 2002/10/06 23:17:46 kristerw Exp $        */
 
 /*-
  * Copyright (c) 2001 The NetBSD Foundation, Inc.
@@ -74,7 +74,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mlx.c,v 1.22 2002/09/27 03:18:13 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mlx.c,v 1.23 2002/10/06 23:17:46 kristerw Exp $");
 
 #include "ld.h"
 
@@ -602,7 +602,6 @@
        if (mes == NULL) {
                printf("%s: error fetching drive status\n",
                    mlx->mlx_dv.dv_xname);
-               free(me, M_DEVBUF);
                goto out;
        }
 
@@ -2219,7 +2218,7 @@
                            mlx->mlx_dv.dv_xname);
                        mlx->mlx_flags |= MLXF_SPINUP_REPORTED;
                }
-               break;
+               return (0);
 
        case 0x30:
                fmt = "configuration checksum error";
@@ -2250,7 +2249,8 @@
                break;
 
        case 0xf0:
-               fmt = "FATAL MEMORY PARITY ERROR";
+               printf("%s: FATAL MEMORY PARITY ERROR\n",
+                   mlx->mlx_dv.dv_xname);
                return (1);
 
        default:



Home | Main Index | Thread Index | Old Index