Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/netbsd-1-6]: src/sys/dev/ic Pull up revision 1.30 (requested by bouyer i...
details: https://anonhg.NetBSD.org/src/rev/199956276411
branches: netbsd-1-6
changeset: 529494:199956276411
user: tron <tron%NetBSD.org@localhost>
date: Sun Nov 24 16:32:48 2002 +0000
description:
Pull up revision 1.30 (requested by bouyer in ticket #747):
The 1010 will generate a scsi gross error if a RAM entry is read before being
written (i.e. is used uninitialised). The esiop SCRIPT may do this in some
circonstances (and it is safe) so bus_space_set_region_4() the RAM in
reset routine.
Problem reported and fix tested by Allen Briggs.
diffstat:
sys/dev/ic/siop_common.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diffs (33 lines):
diff -r 4f132ff9b627 -r 199956276411 sys/dev/ic/siop_common.c
--- a/sys/dev/ic/siop_common.c Sun Nov 24 16:22:07 2002 +0000
+++ b/sys/dev/ic/siop_common.c Sun Nov 24 16:32:48 2002 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: siop_common.c,v 1.28 2002/05/05 15:23:22 bouyer Exp $ */
+/* $NetBSD: siop_common.c,v 1.28.4.1 2002/11/24 16:32:48 tron Exp $ */
/*
* Copyright (c) 2000, 2002 Manuel Bouyer.
@@ -33,7 +33,7 @@
/* SYM53c7/8xx PCI-SCSI I/O Processors driver */
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: siop_common.c,v 1.28 2002/05/05 15:23:22 bouyer Exp $");
+__KERNEL_RCSID(0, "$NetBSD: siop_common.c,v 1.28.4.1 2002/11/24 16:32:48 tron Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -231,6 +231,14 @@
}
sc->mode = bus_space_read_1(sc->sc_rt, sc->sc_rh, SIOP_STEST4) &
STEST4_MODE_MASK;
+
+ /*
+ * initialise the RAM. Without this we may get scsi gross errors on
+ * the 1010
+ */
+ if (sc->features & SF_CHIP_RAM)
+ bus_space_set_region_4(sc->sc_ramt, sc->sc_ramh,
+ 0, 0, sc->ram_size / 4);
sc->sc_reset(sc);
}
Home |
Main Index |
Thread Index |
Old Index