Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/sys/arch/arm/pic pic_pending_zero is unnecessary; percpu_all...
details: https://anonhg.NetBSD.org/src/rev/38295533dd30
branches: trunk
changeset: 744432:38295533dd30
user: riastradh <riastradh%NetBSD.org@localhost>
date: Sat Feb 01 12:55:13 2020 +0000
description:
pic_pending_zero is unnecessary; percpu_alloc already zeroes.
diffstat:
sys/arch/arm/pic/pic.c | 19 ++++---------------
1 files changed, 4 insertions(+), 15 deletions(-)
diffs (47 lines):
diff -r 1e58ad81b1ae -r 38295533dd30 sys/arch/arm/pic/pic.c
--- a/sys/arch/arm/pic/pic.c Sat Feb 01 12:55:02 2020 +0000
+++ b/sys/arch/arm/pic/pic.c Sat Feb 01 12:55:13 2020 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: pic.c,v 1.53 2020/02/01 12:55:02 riastradh Exp $ */
+/* $NetBSD: pic.c,v 1.54 2020/02/01 12:55:13 riastradh Exp $ */
/*-
* Copyright (c) 2008 The NetBSD Foundation, Inc.
* All rights reserved.
@@ -33,7 +33,7 @@
#include "opt_multiprocessor.h"
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: pic.c,v 1.53 2020/02/01 12:55:02 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pic.c,v 1.54 2020/02/01 12:55:13 riastradh Exp $");
#include <sys/param.h>
#include <sys/atomic.h>
@@ -616,15 +616,6 @@
#endif
}
-#if defined(__HAVE_PIC_PENDING_INTRS) && defined(MULTIPROCESSOR)
-static void
-pic_pending_zero(void *v0, void *v1, struct cpu_info *ci)
-{
- struct pic_pending * const p = v0;
- memset(p, 0, sizeof(*p));
-}
-#endif /* __HAVE_PIC_PENDING_INTRS && MULTIPROCESSOR */
-
static int
pic_init(void)
{
@@ -646,10 +637,8 @@
KASSERT(strlen(pic->pic_name) > 0);
#if defined(__HAVE_PIC_PENDING_INTRS) && defined(MULTIPROCESSOR)
- if (__predict_false(pic_pending_percpu == NULL)) {
- pic_pending_percpu = percpu_create(sizeof(struct pic_pending),
- pic_pending_zero, NULL, NULL);
- }
+ if (__predict_false(pic_pending_percpu == NULL))
+ pic_pending_percpu = percpu_alloc(sizeof(struct pic_pending));
#endif /* __HAVE_PIC_PENDING_INTRS && MULTIPROCESSOR */
mutex_enter(&pic_lock);
Home |
Main Index |
Thread Index |
Old Index