Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/opencrypto softint_disestablish does xc_barrier(0) for u...



details:   https://anonhg.NetBSD.org/src/rev/ae33efe8ee9e
branches:  trunk
changeset: 744440:ae33efe8ee9e
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sat Feb 01 13:48:08 2020 +0000

description:
softint_disestablish does xc_barrier(0) for us already.

diffstat:

 sys/opencrypto/crypto.c |  10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diffs (38 lines):

diff -r bd148a1152a4 -r ae33efe8ee9e sys/opencrypto/crypto.c
--- a/sys/opencrypto/crypto.c   Sat Feb 01 13:40:55 2020 +0000
+++ b/sys/opencrypto/crypto.c   Sat Feb 01 13:48:08 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: crypto.c,v 1.111 2020/02/01 12:54:30 riastradh Exp $ */
+/*     $NetBSD: crypto.c,v 1.112 2020/02/01 13:48:08 riastradh Exp $ */
 /*     $FreeBSD: src/sys/opencrypto/crypto.c,v 1.4.2.5 2003/02/26 00:14:05 sam Exp $   */
 /*     $OpenBSD: crypto.c,v 1.41 2002/07/17 23:52:38 art Exp $ */
 
@@ -53,7 +53,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: crypto.c,v 1.111 2020/02/01 12:54:30 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: crypto.c,v 1.112 2020/02/01 13:48:08 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/reboot.h>
@@ -644,10 +644,7 @@
                 * prohibit touch crypto_drivers[] and each element after here.
                 */
 
-               /*
-                * Ensure cryptoret_softint() is never scheduled and then wait
-                * for last softint_execute().
-                */
+               /* Ensure cryptoret_softint() is never scheduled again.  */
                for (i = 0; i < ncpu; i++) {
                        struct crypto_crp_ret_qs *qs;
                        struct cpu_info *ci = cpu_lookup(i);
@@ -656,7 +653,6 @@
                        qs->crp_ret_q_exit_flag = true;
                        crypto_put_crp_ret_qs(ci);
                }
-               xc_barrier(0);
        }
 
        if (sysctl_opencrypto_clog != NULL)



Home | Main Index | Thread Index | Old Index