Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/sys/dev/pci/ixgbe Update comment in ixgbe_update_stats_count...
details: https://anonhg.NetBSD.org/src/rev/2b2879890807
branches: trunk
changeset: 744522:2b2879890807
user: msaitoh <msaitoh%NetBSD.org@localhost>
date: Wed Feb 05 01:44:53 2020 +0000
description:
Update comment in ixgbe_update_stats_counters() to clarify why we update
if_iqdrops and if_ierrors only. No functional change.
OK'd by knakahara and thorpej.
diffstat:
sys/dev/pci/ixgbe/ixgbe.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diffs (28 lines):
diff -r 00fee80fdc0f -r 2b2879890807 sys/dev/pci/ixgbe/ixgbe.c
--- a/sys/dev/pci/ixgbe/ixgbe.c Tue Feb 04 21:34:47 2020 +0000
+++ b/sys/dev/pci/ixgbe/ixgbe.c Wed Feb 05 01:44:53 2020 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: ixgbe.c,v 1.223 2020/02/04 19:42:55 thorpej Exp $ */
+/* $NetBSD: ixgbe.c,v 1.224 2020/02/05 01:44:53 msaitoh Exp $ */
/******************************************************************************
@@ -1708,15 +1708,11 @@
stats->fcoedwtc.ev_count += IXGBE_READ_REG(hw, IXGBE_FCOEDWTC);
}
- /* Fill out the OS statistics structure */
/*
- * NetBSD: Don't override if_{i|o}{packets|bytes|mcasts} with
- * adapter->stats counters. It's required to make ifconfig -z
- * (SOICZIFDATA) work.
+ * Fill out the OS statistics structure. Only RX errors are required
+ * here because all TX counters are incremented in the TX path and
+ * normal RX counters are prepared in ether_input().
*/
- /* XXX Actually, just fill in the per-cpu stats, please !!! */
-
- /* Rx Errors */
net_stat_ref_t nsr = IF_STAT_GETREF(ifp);
if_statadd_ref(nsr, if_iqdrops, total_missed_rx);
if_statadd_ref(nsr, if_ierrors, crcerrs + rlec);
Home |
Main Index |
Thread Index |
Old Index