[src/trunk]: src/sys/dev/ic Disable thrctrl or now and note why

[skrll <skrll%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/a2f6d832b1fd
branches:  trunk
changeset: 746038:a2f6d832b1fd
user:      skrll <skrll%NetBSD.org@localhost>
date:      Fri Mar 20 17:20:30 2020 +0000

description:
Disable thrctrl or now and note why

diffstat:

 sys/dev/ic/dwc_mmc.c |  14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)

diffs (40 lines):

diff -r 4bab14a1022f -r a2f6d832b1fd sys/dev/ic/dwc_mmc.c
--- a/sys/dev/ic/dwc_mmc.c      Fri Mar 20 17:19:25 2020 +0000
+++ b/sys/dev/ic/dwc_mmc.c      Fri Mar 20 17:20:30 2020 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: dwc_mmc.c,v 1.25 2020/03/20 17:07:17 skrll Exp $ */
+/* $NetBSD: dwc_mmc.c,v 1.26 2020/03/20 17:20:30 skrll Exp $ */
 
 /*-
  * Copyright (c) 2014-2017 Jared McNeill <jmcneill%invisible.ca@localhost>
@@ -27,7 +27,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: dwc_mmc.c,v 1.25 2020/03/20 17:07:17 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: dwc_mmc.c,v 1.26 2020/03/20 17:20:30 skrll Exp $");
 
 #include <sys/param.h>
 #include <sys/bus.h>
@@ -662,11 +662,21 @@
                MMC_WRITE(sc, DWC_MMC_BLKSZ, cmd->c_blklen);
                MMC_WRITE(sc, DWC_MMC_BYTECNT,
                    nblks > 1 ? nblks * cmd->c_blklen : cmd->c_datalen);
+
+#if 0
+               /*
+                * The following doesn't work on the 250a verid IP in Odroid-XU4.
+               *
+                * thrctl should only be used for UHS/HS200 and faster timings on
+                * >=240a
+                */
+
                if (ISSET(cmd->c_flags, SCF_CMD_READ)) {
                        MMC_WRITE(sc, DWC_MMC_CARDTHRCTL,
                            __SHIFTIN(cmd->c_blklen, DWC_MMC_CARDTHRCTL_RDTHR) |
                            DWC_MMC_CARDTHRCTL_RDTHREN);
                }
+#endif
        }
 
        MMC_WRITE(sc, DWC_MMC_IMASK, imask | sc->sc_intr_card);