Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/fs/msdosfs Don't double unlock fvp if source file disapp...



details:   https://anonhg.NetBSD.org/src/rev/10ede2377a12
branches:  trunk
changeset: 755171:10ede2377a12
user:      pooka <pooka%NetBSD.org@localhost>
date:      Tue May 25 10:15:34 2010 +0000

description:
Don't double unlock fvp if source file disappears during rename.
Problem found by njoly's awesome stresstester.

diffstat:

 sys/fs/msdosfs/msdosfs_vnops.c |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (26 lines):

diff -r 0e31eacb447f -r 10ede2377a12 sys/fs/msdosfs/msdosfs_vnops.c
--- a/sys/fs/msdosfs/msdosfs_vnops.c    Tue May 25 08:50:54 2010 +0000
+++ b/sys/fs/msdosfs/msdosfs_vnops.c    Tue May 25 10:15:34 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: msdosfs_vnops.c,v 1.65 2010/04/23 15:38:46 pooka Exp $ */
+/*     $NetBSD: msdosfs_vnops.c,v 1.66 2010/05/25 10:15:34 pooka Exp $ */
 
 /*-
  * Copyright (C) 1994, 1995, 1997 Wolfgang Solfrank.
@@ -48,7 +48,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: msdosfs_vnops.c,v 1.65 2010/04/23 15:38:46 pooka Exp $");
+__KERNEL_RCSID(0, "$NetBSD: msdosfs_vnops.c,v 1.66 2010/05/25 10:15:34 pooka Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1059,7 +1059,6 @@
                if (doingdirectory)
                        panic("rename: lost dir entry");
                vrele(ap->a_fvp);
-               VOP_UNLOCK(fvp, 0);
                xp = NULL;
        } else {
                vrele(fvp);



Home | Main Index | Thread Index | Old Index