Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/miscfs/genfs layer_inactive: With specnodes introduced d...



details:   https://anonhg.NetBSD.org/src/rev/620af2a99cac
branches:  trunk
changeset: 760303:620af2a99cac
user:      hannken <hannken%NetBSD.org@localhost>
date:      Sun Jan 02 10:38:02 2011 +0000

description:
layer_inactive: With specnodes introduced during vmlocking2
                it is safe to cache device nodes.

Tested with nullfs only as unionfs with device nodes panics.

diffstat:

 sys/miscfs/genfs/layer_vnops.c |  10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diffs (32 lines):

diff -r 14b2a413d4d5 -r 620af2a99cac sys/miscfs/genfs/layer_vnops.c
--- a/sys/miscfs/genfs/layer_vnops.c    Sun Jan 02 09:40:51 2011 +0000
+++ b/sys/miscfs/genfs/layer_vnops.c    Sun Jan 02 10:38:02 2011 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: layer_vnops.c,v 1.43 2010/07/02 08:09:51 hannken Exp $ */
+/*     $NetBSD: layer_vnops.c,v 1.44 2011/01/02 10:38:02 hannken Exp $ */
 
 /*
  * Copyright (c) 1999 National Aeronautics & Space Administration
@@ -170,7 +170,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: layer_vnops.c,v 1.43 2010/07/02 08:09:51 hannken Exp $");
+__KERNEL_RCSID(0, "$NetBSD: layer_vnops.c,v 1.44 2011/01/02 10:38:02 hannken Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -557,11 +557,9 @@
        struct vnode *vp = ap->a_vp;
 
        /*
-        * ..., but don't cache the device node. Also, if we did a
-        * remove, don't cache the node.
+        * If we did a remove, don't cache the node.
         */
-       *ap->a_recycle = (vp->v_type == VBLK || vp->v_type == VCHR
-           || (VTOLAYER(vp)->layer_flags & LAYERFS_REMOVED));
+       *ap->a_recycle = ((VTOLAYER(vp)->layer_flags & LAYERFS_REMOVED) != 0);
 
        /*
         * Do nothing (and _don't_ bypass).



Home | Main Index | Thread Index | Old Index