Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/alpha/alpha IPI interrupts occur above IPL_VM, so u...



details:   https://anonhg.NetBSD.org/src/rev/e83cf9b9b90f
branches:  trunk
changeset: 747881:e83cf9b9b90f
user:      mhitch <mhitch%NetBSD.org@localhost>
date:      Sun Oct 04 17:00:31 2009 +0000

description:
IPI interrupts occur above IPL_VM, so using IPL_VM in for the tlb shootdown
queue mutex doesn't work very well.  I get various deadlocks and corrupted
queue entries.  Change to IPL_SCHED [IPL_CLOCK] to block IPI interrupts
while the cpu is mucking with the shootdown queue.

diffstat:

 sys/arch/alpha/alpha/pmap.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 018547cc8eac -r e83cf9b9b90f sys/arch/alpha/alpha/pmap.c
--- a/sys/arch/alpha/alpha/pmap.c       Sun Oct 04 16:31:08 2009 +0000
+++ b/sys/arch/alpha/alpha/pmap.c       Sun Oct 04 17:00:31 2009 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: pmap.c,v 1.242 2009/09/10 22:27:11 mhitch Exp $ */
+/* $NetBSD: pmap.c,v 1.243 2009/10/04 17:00:31 mhitch Exp $ */
 
 /*-
  * Copyright (c) 1998, 1999, 2000, 2001, 2007, 2008 The NetBSD Foundation, Inc.
@@ -140,7 +140,7 @@
 
 #include <sys/cdefs.h>                 /* RCS ID & Copyright macro defns */
 
-__KERNEL_RCSID(0, "$NetBSD: pmap.c,v 1.242 2009/09/10 22:27:11 mhitch Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pmap.c,v 1.243 2009/10/04 17:00:31 mhitch Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -962,7 +962,7 @@
        for (i = 0; i < ALPHA_MAXPROCS; i++) {
                TAILQ_INIT(&pmap_tlb_shootdown_q[i].pq_head);
                mutex_init(&pmap_tlb_shootdown_q[i].pq_lock, MUTEX_DEFAULT,
-                   IPL_VM);
+                   IPL_SCHED);
        }
 #endif
 



Home | Main Index | Thread Index | Old Index