[src/trunk]: src/sys/ufs/ffs mount(2) doesn't remove vnodes from the freelist...

[mlelstv <mlelstv%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/08e6a94f95ec
branches:  trunk
changeset: 759997:08e6a94f95ec
user:      mlelstv <mlelstv%NetBSD.org@localhost>
date:      Thu Dec 23 14:43:37 2010 +0000

description:
mount(2) doesn't remove vnodes from the freelist in the error path,
so that they get reused with a invalid pointer to a mount structure.

As a workaround, free the vnodes used to create the in-filesystem journal
immediately.

diffstat:

 sys/ufs/ffs/ffs_wapbl.c |  16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diffs (53 lines):

diff -r 6cd6c5528cdb -r 08e6a94f95ec sys/ufs/ffs/ffs_wapbl.c
--- a/sys/ufs/ffs/ffs_wapbl.c   Thu Dec 23 14:29:52 2010 +0000
+++ b/sys/ufs/ffs/ffs_wapbl.c   Thu Dec 23 14:43:37 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ffs_wapbl.c,v 1.15 2010/02/27 12:04:19 mlelstv Exp $   */
+/*     $NetBSD: ffs_wapbl.c,v 1.16 2010/12/23 14:43:37 mlelstv Exp $   */
 
 /*-
  * Copyright (c) 2003,2006,2008 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ffs_wapbl.c,v 1.15 2010/02/27 12:04:19 mlelstv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ffs_wapbl.c,v 1.16 2010/12/23 14:43:37 mlelstv Exp $");
 
 #define WAPBL_INTERNAL
 
@@ -609,10 +609,12 @@
                return error;
 
        if ((error = UFS_VALLOC(rvp, 0 | S_IFREG, NOCRED, &vp)) != 0) {
-               vput(rvp);
+               VOP_UNLOCK(rvp);
+               vgone(rvp);
                return error;
        }
-       vput(rvp);
+       VOP_UNLOCK(rvp);
+       vgone(rvp);
 
        vp->v_type = VREG;
        ip = VTOI(vp);
@@ -634,7 +636,8 @@
                 */
                ip->i_nlink = 0;
                DIP_ASSIGN(ip, nlink, 0);
-               vput(vp);
+               VOP_UNLOCK(vp);
+               vgone(vp);
 
                return error;
        }
@@ -643,7 +646,8 @@
         * Now that we have the place-holder inode for the journal,
         * we don't need the vnode ever again.
         */
-       vput(vp);
+       VOP_UNLOCK(vp);
+       vgone(vp);
 
        return 0;
 }