Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/lib/librumphijack comment



details:   https://anonhg.NetBSD.org/src/rev/34052103ce00
branches:  trunk
changeset: 762806:34052103ce00
user:      pooka <pooka%NetBSD.org@localhost>
date:      Tue Mar 01 10:47:29 2011 +0000

description:
comment

diffstat:

 lib/librumphijack/hijack.c |  9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diffs (30 lines):

diff -r ef075765b617 -r 34052103ce00 lib/librumphijack/hijack.c
--- a/lib/librumphijack/hijack.c        Tue Mar 01 10:02:11 2011 +0000
+++ b/lib/librumphijack/hijack.c        Tue Mar 01 10:47:29 2011 +0000
@@ -1,4 +1,4 @@
-/*      $NetBSD: hijack.c,v 1.72 2011/02/28 20:39:07 pooka Exp $       */
+/*      $NetBSD: hijack.c,v 1.73 2011/03/01 10:47:29 pooka Exp $       */
 
 /*-
  * Copyright (c) 2011 Antti Kantee.  All Rights Reserved.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: hijack.c,v 1.72 2011/02/28 20:39:07 pooka Exp $");
+__RCSID("$NetBSD: hijack.c,v 1.73 2011/03/01 10:47:29 pooka Exp $");
 
 #define __ssp_weak_name(fun) _hijack_ ## fun
 
@@ -1480,6 +1480,11 @@
                /*
                 * then, open two pipes, one for notifications
                 * to each kernel.
+                *
+                * At least the rump pipe should probably be
+                * cached, along with the helper threads.  This
+                * should give a microbenchmark improvement (haven't
+                * experienced a macro-level problem yet, though).
                 */
                if ((rv = rump_sys_pipe(rpipe)) == -1) {
                        sverrno = errno;



Home | Main Index | Thread Index | Old Index