Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/gpio Don't ignore the gpiobus_close() return value. ...



details:   https://anonhg.NetBSD.org/src/rev/d527110336a6
branches:  trunk
changeset: 771576:d527110336a6
user:      mbalmer <mbalmer%NetBSD.org@localhost>
date:      Fri Nov 25 13:49:43 2011 +0000

description:
Don't ignore the gpiobus_close() return value.  Found by joerg@ using clang.

diffstat:

 sys/dev/gpio/gpio.c |  7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diffs (28 lines):

diff -r 64732d679301 -r d527110336a6 sys/dev/gpio/gpio.c
--- a/sys/dev/gpio/gpio.c       Fri Nov 25 13:45:09 2011 +0000
+++ b/sys/dev/gpio/gpio.c       Fri Nov 25 13:49:43 2011 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: gpio.c,v 1.49 2011/11/14 07:45:54 mbalmer Exp $ */
+/* $NetBSD: gpio.c,v 1.50 2011/11/25 13:49:43 mbalmer Exp $ */
 /*     $OpenBSD: gpio.c,v 1.6 2006/01/14 12:33:49 grange Exp $ */
 
 /*
@@ -19,7 +19,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: gpio.c,v 1.49 2011/11/14 07:45:54 mbalmer Exp $");
+__KERNEL_RCSID(0, "$NetBSD: gpio.c,v 1.50 2011/11/25 13:49:43 mbalmer Exp $");
 
 /*
  * General Purpose Input/Output framework.
@@ -442,8 +442,7 @@
        struct gpio_softc *sc;
 
        sc = device_lookup_private(&gpio_cd, minor(dev));
-       gpiobus_close(sc->sc_gc, sc->sc_dev);
-       return 0;
+       return gpiobus_close(sc->sc_gc, sc->sc_dev);
 }
 
 static int



Home | Main Index | Thread Index | Old Index