[src/trunk]: src/sys/fs/hfs Yes, you need a VOP_UNLOCK() there.

[pooka <pooka%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/694ad9e6f0a9
branches:  trunk
changeset: 749359:694ad9e6f0a9
user:      pooka <pooka%NetBSD.org@localhost>
date:      Fri Nov 27 16:23:23 2009 +0000

description:
Yes, you need a VOP_UNLOCK() there.

diffstat:

 sys/fs/hfs/hfs_subr.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 542d1a837f90 -r 694ad9e6f0a9 sys/fs/hfs/hfs_subr.c
--- a/sys/fs/hfs/hfs_subr.c     Fri Nov 27 16:11:35 2009 +0000
+++ b/sys/fs/hfs/hfs_subr.c     Fri Nov 27 16:23:23 2009 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: hfs_subr.c,v 1.12 2009/03/26 20:05:07 pooka Exp $      */
+/*     $NetBSD: hfs_subr.c,v 1.13 2009/11/27 16:23:23 pooka Exp $      */
 
 /*-
  * Copyright (c) 2005, 2007 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */                                     
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: hfs_subr.c,v 1.12 2009/03/26 20:05:07 pooka Exp $");
+__KERNEL_RCSID(0, "$NetBSD: hfs_subr.c,v 1.13 2009/11/27 16:23:23 pooka Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -230,7 +230,7 @@
                        vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY);
                        (void)VOP_CLOSE(devvp,
                            in_vol->readonly ? FREAD : FREAD | FWRITE, NOCRED);
-                       /* XXX do we need a VOP_UNLOCK() here? */
+                       VOP_UNLOCK(devvp, 0);
                }
 
                free(in_vol->cbdata, M_HFSMNT);