[src/netbsd-6-0]: src Pullup ticket #927:

[martin <martin%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/422dda3d01d5
branches:  netbsd-6-0
changeset: 774838:422dda3d01d5
user:      martin <martin%NetBSD.org@localhost>
date:      Fri Aug 02 20:23:11 2013 +0000

description:
Pullup ticket #927:

sys/kern/uipc_socket.c          1.216

        Fix an inversion in checking for authorization to drop TCP connections
        found (and the obvious fix suggested) by Sander Bos.

Requested by spz.

diffstat:

 doc/CHANGES-6.0.3      |  8 +++++++-
 sys/kern/uipc_socket.c |  6 +++---
 2 files changed, 10 insertions(+), 4 deletions(-)

diffs (46 lines):

diff -r 677e6daa913d -r 422dda3d01d5 doc/CHANGES-6.0.3
--- a/doc/CHANGES-6.0.3 Tue Jul 30 04:09:45 2013 +0000
+++ b/doc/CHANGES-6.0.3 Fri Aug 02 20:23:11 2013 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: CHANGES-6.0.3,v 1.1.2.15 2013/07/30 04:09:45 msaitoh Exp $
+# $NetBSD: CHANGES-6.0.3,v 1.1.2.16 2013/08/02 20:23:11 martin Exp $
 
 A complete list of changes from the NetBSD 6.0.2 release to the NetBSD 6.0.3
 release:
@@ -162,3 +162,9 @@
 
        Stop abusing kmem during softint context to prevent panic.
        [kefren, ticket #921]
+
+sys/kern/uipc_socket.c                         1.216
+
+       Fix an inversion in checking for authorization to drop TCP connections
+       found (and the obvious fix suggested) by Sander Bos.
+       [spz, ticket #927]
diff -r 677e6daa913d -r 422dda3d01d5 sys/kern/uipc_socket.c
--- a/sys/kern/uipc_socket.c    Tue Jul 30 04:09:45 2013 +0000
+++ b/sys/kern/uipc_socket.c    Fri Aug 02 20:23:11 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uipc_socket.c,v 1.209.2.1 2012/07/12 17:11:17 riz Exp $        */
+/*     $NetBSD: uipc_socket.c,v 1.209.2.1.4.1 2013/08/02 20:23:11 martin Exp $ */
 
 /*-
  * Copyright (c) 2002, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -63,7 +63,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.209.2.1 2012/07/12 17:11:17 riz Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.209.2.1.4.1 2013/08/02 20:23:11 martin Exp $");
 
 #include "opt_compat_netbsd.h"
 #include "opt_sock_counters.h"
@@ -416,7 +416,7 @@
                /* Normal users can only drop their own connections. */
                struct socket *so = (struct socket *)arg1;
 
-               if (proc_uidmatch(cred, so->so_cred))
+               if (proc_uidmatch(cred, so->so_cred) == 0)
                        result = KAUTH_RESULT_ALLOW;
 
                break;