Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb don't clear TS_BUSY in ucomclose().



details:   https://anonhg.NetBSD.org/src/rev/8715adb69a0d
branches:  trunk
changeset: 759152:8715adb69a0d
user:      bsh <bsh%NetBSD.org@localhost>
date:      Tue Nov 30 15:26:22 2010 +0000

description:
don't clear TS_BUSY in ucomclose().
This fixes kernel crash in ucomstart() with "echo Hello > /dev/ttyU0".

diffstat:

 sys/dev/usb/ucom.c |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (26 lines):

diff -r 28317f1c24f6 -r 8715adb69a0d sys/dev/usb/ucom.c
--- a/sys/dev/usb/ucom.c        Tue Nov 30 15:25:05 2010 +0000
+++ b/sys/dev/usb/ucom.c        Tue Nov 30 15:26:22 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ucom.c,v 1.85 2010/11/03 22:34:23 dyoung Exp $ */
+/*     $NetBSD: ucom.c,v 1.86 2010/11/30 15:26:22 bsh Exp $    */
 
 /*
  * Copyright (c) 1998, 2000 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ucom.c,v 1.85 2010/11/03 22:34:23 dyoung Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ucom.c,v 1.86 2010/11/30 15:26:22 bsh Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -596,7 +596,6 @@
 
        s = spltty();
        sc->sc_refcnt++;
-       CLR(tp->t_state, TS_BUSY);
 
        (*tp->t_linesw->l_close)(tp, flag);
        ttyclose(tp);



Home | Main Index | Thread Index | Old Index