[src/trunk]: src/sys/arch/xen/xen Don't leak stack content when reading the X...

[jym <jym%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/9bd2b537174e
branches:  trunk
changeset: 780408:9bd2b537174e
user:      jym <jym%NetBSD.org@localhost>
date:      Sun Jul 22 19:30:19 2012 +0000

description:
Don't leak stack content when reading the Xen suspend value.

XXX pull-up to -6.

diffstat:

 sys/arch/xen/xen/xen_machdep.c |  9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diffs (40 lines):

diff -r dc2a7bb8d395 -r 9bd2b537174e sys/arch/xen/xen/xen_machdep.c
--- a/sys/arch/xen/xen/xen_machdep.c    Sun Jul 22 19:07:33 2012 +0000
+++ b/sys/arch/xen/xen/xen_machdep.c    Sun Jul 22 19:30:19 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: xen_machdep.c,v 1.11 2012/06/30 22:50:37 jym Exp $     */
+/*     $NetBSD: xen_machdep.c,v 1.12 2012/07/22 19:30:19 jym Exp $     */
 
 /*
  * Copyright (c) 2006 Manuel Bouyer.
@@ -53,7 +53,7 @@
 
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: xen_machdep.c,v 1.11 2012/06/30 22:50:37 jym Exp $");
+__KERNEL_RCSID(0, "$NetBSD: xen_machdep.c,v 1.12 2012/07/22 19:30:19 jym Exp $");
 
 #include "opt_xen.h"
 
@@ -247,7 +247,7 @@
            CTL_CREATE, CTL_EOL);
 
        sysctl_createv(NULL, 0, &node, &node,
-           CTLFLAG_PERMANENT | CTLFLAG_READWRITE,
+           CTLFLAG_PERMANENT | CTLFLAG_READWRITE | CTLFLAG_IMMEDIATE,
            CTLTYPE_INT, "suspend",
            SYSCTL_DESCR("Suspend/save current Xen domain"),
            sysctl_xen_suspend, 0, NULL, 0,
@@ -257,11 +257,10 @@
 static int
 sysctl_xen_suspend(SYSCTLFN_ARGS)
 {
-       int error, t;
+       int error;
        struct sysctlnode node;
 
        node = *rnode;
-       node.sysctl_data = &t;
        error = sysctl_lookup(SYSCTLFN_CALL(&node));
 
        if (error || newp == NULL)