Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci #if 0 some diagnostic code that compares two bus...



details:   https://anonhg.NetBSD.org/src/rev/eba96185c56d
branches:  trunk
changeset: 753322:eba96185c56d
user:      dyoung <dyoung%NetBSD.org@localhost>
date:      Mon Mar 22 22:36:07 2010 +0000

description:
#if 0 some diagnostic code that compares two bus_space_tag_t's.

MI code should not compare an opaque type such as bus_space_tag_t!

diffstat:

 sys/dev/pci/cy82c693.c |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (29 lines):

diff -r c150b3980da0 -r eba96185c56d sys/dev/pci/cy82c693.c
--- a/sys/dev/pci/cy82c693.c    Mon Mar 22 22:30:58 2010 +0000
+++ b/sys/dev/pci/cy82c693.c    Mon Mar 22 22:36:07 2010 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: cy82c693.c,v 1.6 2008/04/28 20:23:54 martin Exp $ */
+/* $NetBSD: cy82c693.c,v 1.7 2010/03/22 22:36:07 dyoung Exp $ */
 
 /*-
  * Copyright (c) 2000 The NetBSD Foundation, Inc.
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cy82c693.c,v 1.6 2008/04/28 20:23:54 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cy82c693.c,v 1.7 2010/03/22 22:36:07 dyoung Exp $");
 
 #include "opt_multiprocessor.h"
 #include "opt_lockdebug.h"
@@ -79,8 +79,10 @@
 
        if (cyhc_initialized) {
                CYHC_UNLOCK(s);
+#if 0  /* XXX Comparing bus_space_tag_t is a no-no! */
                if (iot != cyhc_handle.cyhc_iot)
                        panic("cy82c693_init");
+#endif
                return (&cyhc_handle);
        }
 



Home | Main Index | Thread Index | Old Index