Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/lib/libc/time Revert previous - casting to long is a bad ide...
details: https://anonhg.NetBSD.org/src/rev/3ab270bb35ea
branches: trunk
changeset: 782277:3ab270bb35ea
user: martin <martin%NetBSD.org@localhost>
date: Thu Oct 25 15:04:05 2012 +0000
description:
Revert previous - casting to long is a bad idea, as the value will overflow.
Pointed out by apb.
diffstat:
lib/libc/time/zic.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diffs (44 lines):
diff -r 356e2f574ab5 -r 3ab270bb35ea lib/libc/time/zic.c
--- a/lib/libc/time/zic.c Thu Oct 25 13:14:32 2012 +0000
+++ b/lib/libc/time/zic.c Thu Oct 25 15:04:05 2012 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: zic.c,v 1.33 2012/10/25 13:14:32 martin Exp $ */
+/* $NetBSD: zic.c,v 1.34 2012/10/25 15:04:05 martin Exp $ */
/*
** This file is in the public domain, so clarified as of
** 2006-07-17 by Arthur David Olson.
@@ -10,7 +10,7 @@
#include <sys/cdefs.h>
#ifndef lint
-__RCSID("$NetBSD: zic.c,v 1.33 2012/10/25 13:14:32 martin Exp $");
+__RCSID("$NetBSD: zic.c,v 1.34 2012/10/25 15:04:05 martin Exp $");
#endif /* !defined lint */
#include "version.h"
@@ -1128,11 +1128,11 @@
error(_("time before zero"));
return;
}
- if (dayoff < (long)(min_time / SECSPERDAY)) {
+ if (dayoff < min_time / SECSPERDAY) {
error(_("time too small"));
return;
}
- if (dayoff > (long)(max_time / SECSPERDAY)) {
+ if (dayoff > max_time / SECSPERDAY) {
error(_("time too large"));
return;
}
@@ -2522,9 +2522,9 @@
will not work with pre-2004 versions of zic"));
}
}
- if (dayoff < (long)(min_time / SECSPERDAY))
+ if (dayoff < min_time / SECSPERDAY)
return min_time;
- if (dayoff > (long)(max_time / SECSPERDAY))
+ if (dayoff > max_time / SECSPERDAY)
return max_time;
t = (zic_t) dayoff * SECSPERDAY;
return tadd(t, rp->r_tod);
Home |
Main Index |
Thread Index |
Old Index