[src/trunk]: src/sys/arch/i386/i386 in osyscall, set the PSL_I bit into the c...

[chs <chs%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/4dc3ef52c863
branches:  trunk
changeset: 782291:4dc3ef52c863
user:      chs <chs%NetBSD.org@localhost>
date:      Fri Oct 26 14:46:44 2012 +0000

description:
in osyscall, set the PSL_I bit into the correct field of the trapframe.
it was going into tf_eip instead of tf_eflags, which would sometimes
corrupt %eip and always return to user mode with interrupts disabled.
this was found with a netbsd 1.0 binary, and dsl@ points out that
this should also fix PR 41342.

diffstat:

 sys/arch/i386/i386/locore.S |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 489818c17cee -r 4dc3ef52c863 sys/arch/i386/i386/locore.S
--- a/sys/arch/i386/i386/locore.S       Fri Oct 26 12:42:10 2012 +0000
+++ b/sys/arch/i386/i386/locore.S       Fri Oct 26 14:46:44 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: locore.S,v 1.102 2012/09/01 23:19:46 cherry Exp $      */
+/*     $NetBSD: locore.S,v 1.103 2012/10/26 14:46:44 chs Exp $ */
 
 /*
  * Copyright-o-rama!
@@ -129,7 +129,7 @@
  */
 
 #include <machine/asm.h>
-__KERNEL_RCSID(0, "$NetBSD: locore.S,v 1.102 2012/09/01 23:19:46 cherry Exp $");
+__KERNEL_RCSID(0, "$NetBSD: locore.S,v 1.103 2012/10/26 14:46:44 chs Exp $");
 
 #include "opt_compat_oldboot.h"
 #include "opt_ddb.h"
@@ -1130,7 +1130,7 @@
 #endif
        pushfl                  # set eflags in trap frame
        popl    8(%esp)
-       orl     $PSL_I,(%esp)   # re-enable ints on return to user
+       orl     $PSL_I,8(%esp)  # re-enable ints on return to user
        pushl   $7              # size of instruction for restart
        jmp     syscall1
 IDTVEC_END(osyscall)